ENH: show file/line in facility log message#346
Merged
Conversation
tangkong
approved these changes
Jul 13, 2022
Contributor
tangkong
left a comment
There was a problem hiding this comment.
LGTM. Simple and clean, adding some very much needed information for debugging.
ZLLentz
approved these changes
Jul 14, 2022
Member
ZLLentz
left a comment
There was a problem hiding this comment.
This looks good to me too, good extra info for the facility logger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Show source of exception in facility log message summary, such as:
(from user input)
(from a thread - showing the closest input number)
Motivation and Context
The current message is insufficient to get an idea of what happened (from Grafana):
pcdsutils will need an update to include this information in the JSON sent to logstash as well.Related PR (not required for this PR): pcdshub/pcdsutils#65
How Has This Been Tested?
Locally, so far
Where Has This Been Documented?
PR text