ENH: add LazyWidget#55
Merged
Merged
Conversation
ZLLentz
reviewed
Jun 2, 2022
| self.widget = None | ||
|
|
||
| self.setVisible(False) | ||
| self.setLayout(QtWidgets.QVBoxLayout()) |
Member
There was a problem hiding this comment.
I see no reason not to merge this utility, but one small thought: does this create any subtle layout problems with the default margins of QVBoxLayout?
Contributor
Author
There was a problem hiding this comment.
I think there are improvements that could be made with respect to layout padding/margins, for sure. The subtleties were not investigated at all.
I'd be OK with either:
- Iterating on this prior to merging (as we have no immediate need)
- Or merging and then circling back (when the need arises)
Member
There was a problem hiding this comment.
Ok, I'm going to press the merge button then.
I only mentioned margins here because the default margins on all layouts is nonzero, so I expect all LazyWidgets to be slightly smaller than intended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Untested LazyWidget, borrowed/tweaked from pcdshub/typhos#500
Motivation and Context
How Has This Been Tested?
Where Has This Been Documented?