Skip to content

CI: move to GitHub actions#69

Merged
klauer merged 5 commits into
pcdshub:masterfrom
klauer:enh_github_actions_ci
Jan 11, 2023
Merged

CI: move to GitHub actions#69
klauer merged 5 commits into
pcdshub:masterfrom
klauer:enh_github_actions_ci

Conversation

@klauer
Copy link
Copy Markdown
Contributor

@klauer klauer commented Jan 9, 2023

Description

  • Remove Travis CI Configuration
  • Enable GitHub Actions on pcdsutils

Motivation and Context

Result of actions from my fork with this PR branch: https://github.com/klauer/pcdsutils/actions/runs/3878848661

I'm not sure we can get pcdshub/pcdsutils to show Actions checks until the repository contains workflows itself. (I'd be happy to be proved wrong here, though)

Comment thread .github/workflows/standard.yml Outdated
@klauer klauer requested review from ZLLentz and tangkong January 10, 2023 18:59
Copy link
Copy Markdown
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results speak for themselves, looks good to me.

This might be better addressed in the cookiecutter repo, but are we fully moving away from the run_tests.py file in favor of just running pytest? If so we should change the documentation on the cookiecutter to reflect that. (I don't think I saw that being changed, but also I don't see run_tests.py in there)

@klauer
Copy link
Copy Markdown
Contributor Author

klauer commented Jan 10, 2023

This might be better addressed in the cookiecutter repo, but are we fully moving away from the run_tests.py file in favor of just running pytest? If so we should change the documentation on the cookiecutter to reflect that. (I don't think I saw that being changed, but also I don't see run_tests.py in there)

I'm of the opinion that run_tests.py should go away, as I think it's unnecessary boilerplate. We're a team (of course!), though, so we should agree on it first.

I think the existence of the cookiecutter (whether used often or not) is a great place to show off all of our agreed-upon standards in a concrete way that can be replicated elsewhere (and propagated to existing repositories, when feasible)

@tangkong
Copy link
Copy Markdown
Contributor

I've personally never used run_tests.py, and would be fine seeing it go 👍

Comment thread run_tests.py
@@ -1,49 +0,0 @@
#!/usr/bin/env python
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on removing these run_tests files, it's good timing to do it

Copy link
Copy Markdown
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just have to redirect the workflow url

@klauer
Copy link
Copy Markdown
Contributor Author

klauer commented Jan 11, 2023

Merging this and following up with a test PR to verify that actions are really working here (they are on my fork's actions, as above)

@klauer klauer merged commit 837354a into pcdshub:master Jan 11, 2023
@klauer klauer deleted the enh_github_actions_ci branch January 11, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants