Fix of pwm.py to work with the new sysfs on V3b #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f youput the specified value from 'max_level' as 'level' by letting it only go to 1 less
The new pwm-sysfs somehow has a higher priority than digital gpio, so i changed the pin_mode function to disable pwm, if the pin supports it.
Contributor
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed the pwm-module to work on my PcDuino V3B with it's new sysfs, however I'm unable to test it on other PcDuinos, I'll leave that to you.
I'm pretty new to Git so feel free to disregard the intermediate commits, it should have been one commit.
Edit: I just added the fourth commit, that adjusts the gpio module to disable pwm before using pin_mode, otherwise digital_write has no effect.