Usage as embedded JPanel

[magethle]

When using icepdf as embedded JPanel using new SwingViewBuilder(...).buildViewerPanel(), then SwingContoller.viewer remains null.
But this means that dialogs don't have a parent, see various openDocument methods (I'm using the variant using an InputStream), or saveFileAs().
Wouldn't it be correct to use the JPanel instance as parent in these cases?
Probably it's not a great problem when calling Resources.showMessageDialog(null, ...), I'm not sure about that?
But when saving a PDF it crashes when calling fileDialog.setVisible(true) as fileDialog has no parent in that case.
By setting the system property org.icepdf.ri.viewer.jfilechooser to true I was able to avoid this problem, so I don't know if it was introduced for that purpose? But again, the dialog doesn't have a parent and isn't modal... so from the user's perspective it's not ideal.

[pcorless]

I think I understand.

The org.icepdf.ri.viewer.jfilechooser property is simply just a switch, the choice was for operating systems where one or the other dialog looked better. I'll see what I can do about hooking up a parent for the component use case.

[pcorless]

Did quite a bit a of cleanup to make sure the dialogs are finding a root frame. Likely still some issue with embedding in JavaFX but I'll save that for another try.

[magethle]

I did a quick test and it works. But I have to set org.icepdf.ri.viewer.jfilechooser to true otherwise it crashes (see my comment on the PR).
I will test it more thoroughly next week.

[pcorless]

I dug into this a bit more and it reads like JFileChooser() is the way to go. Also so one example for using a hidden Frame to launch the dialog.

I guess too if you wanted to do some extra lifting it would theoretically possible to write your own method that used a SWT FileDialog.

[pcorless]

Closing, org.icepdf.ri.viewer.jfilechooser=true is the best option for working with SWT.