Skip to content

feat(github): releases, gists(graphql)#179

Merged
pd4d10 merged 2 commits intopd4d10:mainfrom
shreyas1599:github-graphql-1
Jan 31, 2021
Merged

feat(github): releases, gists(graphql)#179
pd4d10 merged 2 commits intopd4d10:mainfrom
shreyas1599:github-graphql-1

Conversation

@shreyas1599
Copy link
Contributor

@shreyas1599 shreyas1599 commented Jan 30, 2021

  • Gists (graphql)
  • Releases (download url is the first downloadable asset)
  • Graphql response does not return source code assets:
    in the below image only the apk asset is returned.

image

  • Possible Improvement: If a release has multiple non-source code assets then use SimpleDialog, but there is no equivalent cupertino widget. Not sure if we should create a separate screen just for this?

  • Screenshot
    image

@pd4d10
Copy link
Owner

pd4d10 commented Jan 30, 2021

Thanks!

I'm thinking if we should add more information to the releases page. This is the mobile web version:

simulator_screenshot_E9D7D45E-AABD-4814-9002-A630C9EC071F

@shreyas1599
Copy link
Contributor Author

I thought about this. There's a description prop for release but it does not seem to output what I thought it would (the "bug fixes" text in the image you included). It returns an empty string. Not sure if it's a bug or if it means something else. I've included all useful information exposed through the connection(except releasesCount. I'll add that). It's only there in 'REST`. Example url. Even the source code zip and tarball files are in here. Should we change it to rest or wait for github to expose these through graphql? I'll file an issue in github.community?

@pd4d10
Copy link
Owner

pd4d10 commented Jan 30, 2021

change it to rest or wait for github to expose these through graphql

I think both would be fine. At least we could use the web version

file an issue in github.community

It's a good idea. But I'm not sure if it is in the official plan

@shreyas1599
Copy link
Contributor Author

There's a description prop for release but it does not seem to output what I thought it would (the "bug fixes" text in the image you included). It returns an empty string. Not sure if it's a bug or if it means something else.

Sorry my bad. the description returns a proper response. I was looking at earlier releases which had no descriptions. I ordered by descending order and the description works as expected.

@pd4d10 pd4d10 mentioned this pull request Jan 31, 2021
@shreyas1599
Copy link
Contributor Author

Hi @pd4d10, I made a few changes. I thought it'd be better to list the assets and add a download button within the app itself instead of redirecting) Looks like this now:

Screenshot_1612089261

@pd4d10
Copy link
Owner

pd4d10 commented Jan 31, 2021

The lint is fixed in the latest main branch. Could you do a rebase?

fix: zero release assets

fix: use description, assets drop down, desc order
@pd4d10 pd4d10 merged commit fba6e4c into pd4d10:main Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants