Skip to content

fix(gh issue): null check error#241

Closed
shreyas1599 wants to merge 2 commits intopd4d10:mainfrom
shreyas1599:null-check-fix
Closed

fix(gh issue): null check error#241
shreyas1599 wants to merge 2 commits intopd4d10:mainfrom
shreyas1599:null-check-fix

Conversation

@shreyas1599
Copy link
Copy Markdown
Contributor

  • null check error in gh_issue
  • a couple of lint errors were auto-fixed
  • fixed the following messages
  String get _keyword => _controller!.text?.trim() ?? '';
                                      ^
lib/screens/gh_repo.dart:273:54: Warning: Operand of null-aware operation '?.' has type 'GRepoCommit_history' which excludes null.
 - 'GRepoCommit_history' is from 'package:git_touch/graphql/github.data.gql.dart' ('lib/graphql/github.data.gql.dart').
                        ((ref.target as GRepoCommit).history?.totalCount ?? 0)
                                                     ^
lib/screens/gl_search.dart:29:39: Warning: Operand of null-aware operation '?.' has type 'String' which excludes null.
  String get _keyword => _controller!.text?.trim() ?? '';
                                      ^
lib/screens/gh_search.dart:28:39: Warning: Operand of null-aware operation '?.' has type 'String' which excludes null.
  String get _keyword => _controller!.text?.trim() ?? '';

image

@shreyas1599
Copy link
Copy Markdown
Contributor Author

Not sure why repository_item is flagged in the check. Is unchanged on my local machine when I run dartfmt

@pd4d10
Copy link
Copy Markdown
Owner

pd4d10 commented Jun 8, 2021

Sorry, just pushed my local changes and there may be some conflicts.

Could you please solve these? Thanks!

@shreyas1599
Copy link
Copy Markdown
Contributor Author

Sorry, just pushed my local changes and there may be some conflicts.

Could you please solve these? Thanks!

Looks like your latest commit includes the changes I made in this pr. Closing this.

@shreyas1599 shreyas1599 closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants