Merged
Conversation
Owner
|
Thanks for the PR. Great work! I'm not quite sure what these 3 types meant for. Perhaps we could leave these as is? |
Owner
|
This issue is added over a year. Time to close it! |
pd4d10
approved these changes
Apr 8, 2020
Contributor
Author
|
Alright 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
CommitCommentThreadPullRequestReviewThreadPullRequestReviewCommentApart from the above three, I've implemented everything else.
I also updated the
LockedEventto useassigneeinstead of the now deprecateduser.I'm not exactly sure how to implement these. Aren't these already built by the final widget
build? I could just modify theifstatement of the final widgetbuildto include the above three events. Would I be right in doing so?