Skip to content

feat: contributor screen#64

Merged
pd4d10 merged 3 commits intopd4d10:masterfrom
shreyas1599:contributor-screen
Apr 25, 2020
Merged

feat: contributor screen#64
pd4d10 merged 3 commits intopd4d10:masterfrom
shreyas1599:contributor-screen

Conversation

@shreyas1599
Copy link
Contributor

Partially completes #53

  • Added only for github. There were two ways to do this. Either using /repos/:owner/:repo/stats/contributors or /repos/:owner/:repo/contributors. The former could not be paginated which resulted in problems. The only benefit of the former was getting number of additions and deletions on a weekly basis. The latter provides information only about total commits which I hope is enough. Attaching pictures for reference.

image
image

Let me know if there are any changes to be made. Thanks.

@pd4d10
Copy link
Owner

pd4d10 commented Apr 23, 2020

Great! Sorry for the late response. I'll take a look this weekend

@pd4d10
Copy link
Owner

pd4d10 commented Apr 25, 2020

Hi, @shreyas1599 , you could run dartfmt --overwrite lib/**/*.dart to format code, so the CI step would not fail. If you are using IDE like VSCode or Android Studio, the format tool should already be built-in in the Flutter plugin.

@shreyas1599 shreyas1599 requested a review from pd4d10 April 25, 2020 10:28
@pd4d10 pd4d10 merged commit be30bcb into pd4d10:master Apr 25, 2020
@pd4d10
Copy link
Owner

pd4d10 commented Apr 25, 2020

Thanks!

@shreyas1599 shreyas1599 deleted the contributor-screen branch May 8, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants