Skip to content

feat: gists screen#80

Merged
pd4d10 merged 7 commits intopd4d10:masterfrom
shreyas1599:gists-screen
May 14, 2020
Merged

feat: gists screen#80
pd4d10 merged 7 commits intopd4d10:masterfrom
shreyas1599:gists-screen

Conversation

@shreyas1599
Copy link
Contributor

@shreyas1599 shreyas1599 commented May 6, 2020 •
edited
Loading

#80

  • I was not sure how to name the URL for gists.
  • I haven't added a route for blob view of files yet.

pd4d10
pd4d10 reviewed May 6, 2020
View reviewed changes
pd4d10
pd4d10 reviewed May 6, 2020
View reviewed changes
pd4d10
pd4d10 reviewed May 7, 2020
View reviewed changes
@shreyas1599 shreyas1599 marked this pull request as ready for review May 13, 2020 10:49
@shreyas1599
Copy link
Contributor Author

shreyas1599 commented May 13, 2020

@pd4d10 The object type error was caused by the type in ObjectTreeItem. type in the gists json was the language of the file. It works now.

@shreyas1599 shreyas1599 requested a review from pd4d10 May 13, 2020 11:14
pd4d10
pd4d10 reviewed May 14, 2020
View reviewed changes
@pd4d10 pd4d10 merged commit 094ad4b into pd4d10:master May 14, 2020
@shreyas1599 shreyas1599 deleted the gists-screen branch May 14, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pd4d10 pd4d10 pd4d10 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shreyas1599 @pd4d10