Allow PDFKit middleware to receive javascript delay option#391
Merged
serene merged 1 commit intopdfkit:masterfrom Jan 22, 2019
Merged
Allow PDFKit middleware to receive javascript delay option#391serene merged 1 commit intopdfkit:masterfrom
serene merged 1 commit intopdfkit:masterfrom
Conversation
sigmavirus24
approved these changes
Mar 4, 2017
Contributor
sigmavirus24
left a comment
sigmavirus24
left a comment
There was a problem hiding this comment.
This looks good to me.
serene
approved these changes
Jan 6, 2018
jspears
pushed a commit
to jspears/pdfkit-support-color-emoji
that referenced
this pull request
Feb 22, 2026
…sed on #986. Fixes pdfkit#477 #877 pdfkit#391
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows the page to respond with a dynamically calculated javascript delay option through the header
The code could be made pretty generic if the desire to pass other options back through was needed?