PDFCLOUD-5549 Add Blank PDF client methods#14
Merged
datalogics-kam merged 8 commits intopdfrest:mainfrom Feb 17, 2026
Merged
Conversation
datalogics-cgreen
changed the title
datalogics-cgreen
force-pushed
the
pdfcloud-5464-blank-pdf
branch
2 times, most recently
from
32c7f04 to
7c6dcbb
Compare
datalogics-cgreen
force-pushed
the
pdfcloud-5464-blank-pdf
branch
from
7c6dcbb to
1215e68
Compare
Contributor
|
Looks like this needs a rebase, Chris. |
datalogics-kam
requested changes
Feb 11, 2026
Contributor
datalogics-kam
left a comment
datalogics-kam
left a comment
There was a problem hiding this comment.
First pass...please remove code that violates SOLID, and make the suggested change to make endpoints work that don't have input_id.
datalogics-cgreen
force-pushed
the
pdfcloud-5464-blank-pdf
branch
2 times, most recently
from
327d68a to
66d0c33
Compare
datalogics-kam
requested changes
Feb 12, 2026
Contributor
datalogics-kam
left a comment
datalogics-kam
left a comment
There was a problem hiding this comment.
There is still an incorrect handling of empty input ids.
datalogics-cgreen
force-pushed
the
pdfcloud-5464-blank-pdf
branch
from
66d0c33 to
c6f5205
Compare
datalogics-kam
requested changes
Feb 13, 2026
Contributor
datalogics-kam
left a comment
datalogics-kam
left a comment
There was a problem hiding this comment.
Asking for
- Less complicated interface for page sizes
- Defaults surfaced.
Contributor
Author
|
I can absolutely set sensible default values here; they just wouldn't reflect expectations from the server. |
datalogics-cgreen
force-pushed
the
pdfcloud-5464-blank-pdf
branch
from
83b8dc2 to
7491bfd
Compare
Contributor
I think per our recent discussions, the server does something for the values if they're not specified, and that something should be the default at the client.py level. It makes the interface clearer and easier to use. |
datalogics-kam
requested changes
Feb 17, 2026
Contributor
datalogics-kam
left a comment
datalogics-kam
left a comment
There was a problem hiding this comment.
- Use TypedDict instead of tuple for custom page size. It's clearer, and types like TypedDict are designed to make names/keys obvious. (There's also NamedTuple, but we haven't used that yet, and let's not start at this moment.)
- Please surface defaults for orientation and page count all the way to the public interface, also the page size.
- Codex PR Reviewer had no findings.
- Add `blank_pdf()` sync and async methods - Ensure compatibility with Blank PDF response: - Allow PdfRestRawFileResponse.input_id to default empty so missing inputId doesn’t fail validation - When normalizing file responses, fall back to raw ids (outputId) when inputId is absent for blank-pdf - Document blank-pdf handling to keep response construction working without server-provided input ids Assisted-by: Codex
- Add full sync+async unit parametrization for blank_pdf page-size/page-orientation literals across all standard sizes. - Add explicit boundary tests for page_count (min/max success and below/above range validation) and custom dimension validation for non-positive values. Assisted-by: Codex
- Add a shared literal case matrix to live blank-pdf tests covering all accepted page_size values, both page_orientation literals, and custom dimensions. - Keep explicit invalid extra_body overrides for both transports to verify server errors on unsupported page_size values. Assisted-by: Codex
Assisted-by: Codex
Page size can be either a `str` literal or custom dimensions Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
datalogics-cgreen
force-pushed
the
pdfcloud-5464-blank-pdf
branch
from
7491bfd to
b4ffe7e
Compare
Contributor
|
This failed the required test coverage for new code. You could probably just copy the diff-cover results form the log and ask Codex to write more testing. |
Contributor
|
You can also get coverage differences locally by running the tests and looking at the coverage file. |
Assisted-by: Codex
datalogics-kam
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Blank PDF client support (sync + async) with validated payloads and response normalization for blank-pdf output-only responses.