PDFCLOUD-5554 Add client methods to watermark documents#19
PDFCLOUD-5554 Add client methods to watermark documents#19datalogics-kam merged 12 commits intopdfrest:mainfrom
Conversation
64ee63e to
08e2b8c
Compare
|
@datalogics-kam If you like how text and image watermarks have been split up, I can squash the earlier version (commits). |
81f38cc to
1708407
Compare
|
Let's avoid squashing for now, it makes it hard to reason about the changes. I think for human-originated stuff and small changes it's ok, but let's keep the coding agent history. |
datalogics-kam
left a comment
There was a problem hiding this comment.
- Please remove default-merging validation; if anything, that kind of stuff belongs on the payload. If there are problems with default values going to the server, let's talk.
- Let's give the user one color with two possible types, and the default is RGB black.
- Codex complained about changing the name of PdfCmykColor, but I'm glad we fixed that inconsistency.
Codex findings from PR Review skill:
-
[P2] Live coverage gap for split watermark endpoints (missing async image path)
watermark_pdf_with_imagehas live sync coverage but no matching live async success case, so transport parity is incomplete for the new split API surface.- Evidence:
/Users/kam/src/dl/pdfrest-python/tests/live/test_live_watermark_pdf.py:76covers sync image; no corresponding async image success test exists in that module. - Risk: async-only regressions in image watermark request/response behavior could ship undetected.
-
[P2] Missing request-customization/timeout coverage for image watermark helper
- The suite verifies
extra_query/extra_headers/extra_body/timeoutonly forwatermark_pdf_with_text, not forwatermark_pdf_with_image. - Evidence: customization tests are text-only at
/Users/kam/src/dl/pdfrest-python/tests/test_watermark_pdf.py:149and/Users/kam/src/dl/pdfrest-python/tests/test_watermark_pdf.py:435; no image equivalent present. - Risk: plumbing regressions specific to the image helper (headers/query/body merge or timeout propagation) may slip through.
- The suite verifies
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
1708407 to
4ec78e7
Compare
✅ Deploy Preview for pdfrest-python ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Assisted-by: Codex
datalogics-kam
left a comment
There was a problem hiding this comment.
Please address the changes requested. I will make modifications to AGENTS.md to cause Codex to follow the conventions in the future.
f50c49c to
05287e2
Compare
Assisted-by: Codex
- text_size - opacity - watermark_file_scale Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
05287e2 to
2284c55
Compare
Assisted-by: Codex
datalogics-kam
left a comment
There was a problem hiding this comment.
The text_color distribution to pdfRest fields is even more clever than I thought...approved.
PDFCLOUD-5554
Adds a new Watermark PDF client helper and supporting payload/type definitions.
Introduces comprehensive unit and live test coverage for the watermark endpoint.