Skip to content

PDFCLOUD-5585 Update PR Review Auditor to use merge base#28

Merged
datalogics-cgreen merged 1 commit intopdfrest:mainfrom
datalogics-kam:pdfcloud-5585-update-pr-review-skill
Feb 17, 2026
Merged

PDFCLOUD-5585 Update PR Review Auditor to use merge base#28
datalogics-cgreen merged 1 commit intopdfrest:mainfrom
datalogics-kam:pdfcloud-5585-update-pr-review-skill

Conversation

@datalogics-kam
Copy link
Copy Markdown
Contributor

PDFCLOUD-5585

Summary

This change fixes the PR review skill so it audits only the commits that actually belong to the PR branch.
Before this, the audit range was based on <base_remote>/<base>..HEAD, which can include unrelated changes whenever the base branch advances after the feature branch is cut.

Problem Solved

Using the moving tip of the base branch as the start of the diff creates noisy review context:

  • findings can include code the PR author did not touch,
  • review output can change over time for the same branch,
  • automated reviews become harder to trust and less reproducible.

What Changed

The PR review auditor now computes merge-base and uses <merge_base>..HEAD as the review range end-to-end:

  • context collection script now emits merge-base-based range,
  • usage examples and checklist guidance were updated to match,
  • skill metadata and default prompt now describe merge-base semantics.

Benefits

  • More accurate review scope (PR-owned changes only)
  • Fewer false positives from unrelated base-branch commits
  • Stable, repeatable review results across reruns
  • Better reviewer confidence in findings-first audits

- Changed references from `<base_remote>/<base>..HEAD` to `<merge_base>..HEAD`
  across documentation, scripts, and prompts to align with Git best practices.
- Updated `SKILL.md`, `review-checklist.md`, and agent configuration to reflect
  this change.
- Revised shell scripts (`collect_pr_context.sh` and `review_range.sh`) to
  compute and use `merge-base` for the review range.

Assisted-by: Codex
@datalogics-cgreen datalogics-cgreen merged commit 6387bd1 into pdfrest:main Feb 17, 2026
15 checks passed
@datalogics-kam datalogics-kam deleted the pdfcloud-5585-update-pr-review-skill branch February 17, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants