PDFCLOUD-5463 Add PDF/X, Flatten Forms, and Word, testing update#5
Merged
datalogics-cgreen merged 4 commits intopdfrest:mainfrom Dec 18, 2025
Merged
Conversation
datalogics-kam
changed the title
- Added `test_live_convert_to_pdfx.py` to test PDF to PDF/X conversion with valid and invalid output types. - Added `test_live_convert_to_word.py` to test PDF to Word conversion with support for custom and default output names. - Added `test_live_flatten_pdf_forms.py` to test flattening of PDF forms with validation for custom and default output names. - Introduced new test resource file: `form_with_data.pdf`. Assisted-by: Codex
- Added parameterized tests for `test_convert_to_pdfx_success` and `test_async_convert_to_pdfx_success` to validate multiple output types. - Introduced sync and async tests to verify request customization for PDF to PDF/X, Word, and flattening PDF forms. - Ensured validation logic for accepted input/output types and custom metadata integrations in payload and headers. Assisted-by: Codex
- Added requirement for live pytest modules under `tests/live/` for all new endpoints and services. - Emphasized parameterization, coverage of accepted literals, and at least one invalid input test. - Clarified guidelines for reviewers to block changes without live tests or an explicit follow-up plan. - Enhanced recommendations for pytest parameterization to improve test case clarity and reduce duplication. Assisted-by: Codex
- Recommended using `BeforeValidator` over `@field_validator` for declarative validation across schemas. - Documented guidelines for treating `PdfRestClient` and `AsyncPdfRestClient` as context managers for deterministic resource disposal. - Established consistent behavior for handling file uploads, multipart forms, and endpoint parameters, highlighting the use of `PdfRestFile` objects. - Specified rules for serialization and restricted public APIs from exposing internal resource identifiers like `PdfRestFileID`. Assisted-by: Codex
datalogics-kam
force-pushed
the
pdfcloud-5463-three
branch
from
79225ff to
80a6eea
Compare
datalogics-cgreen
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDFCLOUD-5463
Please review/merge #4 first