Skip to content

enable full building for macOS CI#689

Merged
jbigot merged 1 commit intopdidev:mainfrom
Yushan-Wang:688-enable-benchmarking-document-and-fortran-support-in-macos-ci
May 7, 2026
Merged

enable full building for macOS CI#689
jbigot merged 1 commit intopdidev:mainfrom
Yushan-Wang:688-enable-benchmarking-document-and-fortran-support-in-macos-ci

Conversation

@Yushan-Wang
Copy link
Copy Markdown
Member

@Yushan-Wang Yushan-Wang commented Apr 23, 2026

List of things to check before making a PR

Before merging your code, please check the following:

  • you have added a line describing your changes to the Changelog;
  • you have added unit tests for any new or improved feature;
  • in case you updated dependencies, you have checked pdi/docs/CheckList.md;
  • in case of a change in pdi.h, this same change must be reflected in no-pdi/include/pdi.h;
  • you have checked your code format:
    • you have checked that you respect all conventions specified in CONTRIBUTING.md;
    • you have checked that the indentation and formatting conforms to the .clang-format;
    • you have documented with doxygen any new or changed function / class;
  • you have correctly updated the copyright headers:
    • your institution is in the copyright header of every file you (substantially) modified;
    • you have checked that the end-year of the copyright there is the current one;
  • you have updated the AUTHORS file:
    • you have added yourself to the AUTHORS file;
    • if this is a new contribution, you have added it to the AUTHORS file;
  • you have added everything to the user documentation:
    • any new CMake configuration option;
    • any change in the yaml config;
    • any change to the public or plugin API;
    • any other new or changed user-facing feature;
    • any change to the dependencies;
  • you have correctly linked your MR to one or more issues:
    • your MR solves an identified issue;
    • your commit contain the Fix #issue keyword to autoclose the issue when merged.

@Yushan-Wang Yushan-Wang changed the title enable documentation enable full building for macOS CI Apr 23, 2026
@Yushan-Wang Yushan-Wang force-pushed the 688-enable-benchmarking-document-and-fortran-support-in-macos-ci branch from c6d9518 to 41fa651 Compare April 23, 2026 11:30
@Yushan-Wang Yushan-Wang reopened this Apr 23, 2026
@Yushan-Wang Yushan-Wang marked this pull request as ready for review May 4, 2026 09:08
Comment thread pdi/src/fortran/pdi.f90.zpp
Comment thread pdi/src/fortran/pdif.h.zpp
Copy link
Copy Markdown
Member

@jbigot jbigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great news, thanks!

Comment thread pdi/src/fortran/pdi.f90.zpp Outdated
@Yushan-Wang
Copy link
Copy Markdown
Member Author

Can I get a quick review please @pdidev/pdi-developers

@jbigot jbigot force-pushed the 688-enable-benchmarking-document-and-fortran-support-in-macos-ci branch from b2035b1 to b711720 Compare May 7, 2026 13:01
jbigot
jbigot previously approved these changes May 7, 2026
iole-bolognesi
iole-bolognesi previously approved these changes May 7, 2026
Fix pdidev#688

Co-authored-by: Yushan Wang <yushan.wang@cea.fr>
@jbigot jbigot dismissed stale reviews from iole-bolognesi and themself via 5c5e7af May 7, 2026 14:01
@jbigot jbigot force-pushed the 688-enable-benchmarking-document-and-fortran-support-in-macos-ci branch from b711720 to 5c5e7af Compare May 7, 2026 14:01
@jbigot jbigot merged commit a2c395a into pdidev:main May 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable benchmarking, document, and Fortran support in macOS CI Only a few plugin are supported on MacOS

3 participants