Use id to invoke oidc token generation #3442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
That's cool. Thanks |
frostming
approved these changes
Apr 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3442 +/- ##
==========================================
+ Coverage 85.35% 85.60% +0.24%
==========================================
Files 112 112
Lines 11549 11550 +1
Branches 2534 2535 +1
==========================================
+ Hits 9858 9887 +29
+ Misses 1162 1133 -29
- Partials 529 530 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@frostming please wait a bit. I will increase test coverage and want to test it with gitlab, so that I can add some example to the documentation. |
lioman
force-pushed
the
use-id-to-support-different-oicd-platforms
branch
2 times, most recently
from
fc1a995 to
0cd91d7
Compare
lioman
force-pushed
the
use-id-to-support-different-oicd-platforms
branch
from
182aec2 to
37f5aa5
Compare
lioman
force-pushed
the
use-id-to-support-different-oicd-platforms
branch
from
37f5aa5 to
aa5bef3
Compare
Contributor
Author
|
I tested it with gitlab: https://gitlab.com/lioman/nextcloud_news_filter/-/jobs/9627357043 and it works. |
frostming
reviewed
Apr 4, 2025
lioman
force-pushed
the
use-id-to-support-different-oicd-platforms
branch
from
aa5bef3 to
d2a7e52
Compare
frostming
reviewed
Apr 5, 2025
tests/cli/test_publish.py
Outdated
| with pytest.raises(PdmUsageError): | ||
| Repository(project, config=config) | ||
| captured = capsys.readouterr() | ||
| assert "Unable to detect OICD token for CI platform:" in captured.err |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert "Unable to detect OICD token for CI platform:" in captured.err | |
| assert "Unable to detect OIDC token for CI platform:" in captured.err |
Contributor
Author
There was a problem hiding this comment.
Sorry - I screwed up. Fixed it now.
`id` implements detection of different providers, like Github, Gitlab etc. With that pdm does not need to take care of all supported providers and can stand of the shoulder of that library that `twine` uses as well. - removed pdm's implementation of generating a token - add id dependency and use it - add test dependency to mock httpx requests - add test for oidc auth of Repository
lioman
force-pushed
the
use-id-to-support-different-oicd-platforms
branch
from
d2a7e52 to
d4081bc
Compare
frostming
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idimplements detection of different providers, like Github, Gitlab etc. With that pdm does not need to take care of all supported providers and can stand of the shoulder of that library that twine uses as well.iddependency and use itPull Request Checklist
news/describing what is new.Closes: #3441