Skip to content

add: Form Tags and No double submit#37

Merged
BretRen merged 2 commits into
mainfrom
feat/add-form-tags
Apr 20, 2026
Merged

add: Form Tags and No double submit#37
BretRen merged 2 commits into
mainfrom
feat/add-form-tags

Conversation

@BretRen
Copy link
Copy Markdown
Member

@BretRen BretRen commented Apr 20, 2026

No description provided.

@BretRen BretRen linked an issue Apr 20, 2026 that may be closed by this pull request
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Warning

Rate limit exceeded

@BretRen has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 4 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 24 minutes and 4 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f84dd684-cb96-48d4-9bb3-92f0aed61dc8

📥 Commits

Reviewing files that changed from the base of the PR and between 0505c40 and 9fb8a25.

📒 Files selected for processing (4)
  • website/src/lib/components/CharacterCreateModal.svelte
  • website/src/routes/create/+page.svelte
  • website/src/routes/edit/characters/[id]/+page.svelte
  • website/src/routes/edit/cps/[id]/+page.svelte
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-form-tags

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces submission state management across several forms to prevent duplicate requests and refactors them to use standard HTML form elements. Feedback was provided regarding instances where the isSubmitting flag is not correctly reset to false after successful operations or within specific error-handling paths, which would block subsequent submission attempts.

Comment thread website/src/lib/components/CharacterCreateModal.svelte
Comment thread website/src/routes/create/+page.svelte
Comment thread website/src/routes/edit/cps/[id]/+page.svelte
@BretRen BretRen merged commit 13adbaa into main Apr 20, 2026
1 check passed
@BretRen BretRen deleted the feat/add-form-tags branch April 20, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding form tags makes submission easier

1 participant