feat: direct open create char dialog#50
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds character creation functionality to the 'mystuff' page by integrating the CharacterCreateModal component and managing its visibility state. The UI is updated to trigger this modal when users are in the characters view. Feedback was provided to use a two-way binding for the modal's open state to ensure it synchronizes correctly with the parent component when closed internally.
| <button>close</button> | ||
| </form> | ||
| </dialog> | ||
| <CharacterCreateModal open={openCreateCharDialog} afterCreate={() => fetchMyData(mode)} /> |
There was a problem hiding this comment.
The open prop in CharacterCreateModal is defined as $bindable. To ensure the parent state openCreateCharDialog stays synchronized when the modal is closed internally (e.g., via the 'Close' button or after character creation), you should use bind:open. Without this, openCreateCharDialog will remain true in the parent component after the first time the modal is closed, which will prevent the modal from reopening on subsequent clicks.
<CharacterCreateModal bind:open={openCreateCharDialog} afterCreate={() => fetchMyData(mode)} />
1 participant
Description
When users click "Create Your First Character" direct open create char dialog
Related Issue
#44
Type of Change
How to Test
NA
Checklist