added tests for validateDPOP, fixed some validations #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
left 2 checks to be implemented (and tested)
Potherca
requested changes
Sep 13, 2022
Member
Potherca
left a comment
Potherca
left a comment
There was a problem hiding this comment.
The code looks okay, and I can follow what is going one, I do have issues regarding the code coverage. In its current state, I don't think it will run as expected.
made getWebId catch constraints violated exceptions and throw invalid token only then, other exceptions indicate coding errors, so shouldn't be caught added a check that a dpop token is available, if the authorization header specifies it
added check on result fixed reading fixture files added comment for unusual exception test
Potherca
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
left 2 checks to be implemented (and tested)