fix: prevent macOS about:blank popup#269
Merged
dimavedenyapin merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
…openExternal
The setWindowOpenHandler and shell:openExternal IPC handler were passing
URLs to shell.openExternal without validation. When a webview or renderer
triggered window.open('about:blank'), macOS showed an OS-level error
dialog: "There is no application set to open the URL about:blank".
Added URL validation that rejects empty strings, about:blank, about:srcdoc,
and non-http(s)/mailto protocols. Also added setWindowOpenHandler for
webview contents so window.open from embedded webviews is handled
consistently.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setWindowOpenHandlerinsrc/main/index.tsunconditionally passeddetails.urltoshell.openExternal()without validation. When a webview or renderer triggeredwindow.open('about:blank'), macOS showed the OS-level error: "There is no application set to open the URL about:blank".isExternalUrl()validation that rejects empty strings,about:blank,about:srcdoc, and non-http(s)/mailto protocols before callingshell.openExternal().setWindowOpenHandleron webview contents (viaweb-contents-created) sowindow.open()from embedded browser panels is also validated. Also added the same validation to theshell:openExternalIPC handler.Changes
src/main/index.tsisExternalUrl()helper, guardedsetWindowOpenHandleron main window, addedsetWindowOpenHandleron webview contentssrc/main/ipc-handlers.tsshell:openExternalIPC handlerTest plan
target="_blank"links — valid URLs should still open in the default browserabout:blanknavigation attempts no longer trigger the macOS popuppnpm run build)🤖 Generated with Claude Code