fix(request): store correct destination hash for xchain by jjramirezn · Pull Request #437 · peanutprotocol/peanut-ui

jjramirezn · 2024-10-14T11:46:20Z

We only have the destination hash after we fetch it from squid. We were incorrectly storing the origin hash as destination hash

vercel · 2024-10-14T11:46:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 14, 2024 11:49am

coderabbitai · 2024-10-14T11:46:27Z

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the InitialView and SuccessView components. The InitialView component's transaction handling logic is simplified by removing the fulfillment processing when transactions are not cross-chain. In contrast, the SuccessView component is enhanced to support cross-chain functionality, accepting a new prop for token price data and adjusting its rendering logic based on the transaction's characteristics.

Changes

File Path	Change Summary
`src/components/Request/Pay/Views/Initial.view.tsx`	Simplified `handleOnNext` function by removing fulfillment processing for non-cross-chain transactions, only setting the transaction hash and calling `onNext`.
`src/components/Request/Pay/Views/Success.view.tsx`	Enhanced to support cross-chain functionality with a new `tokenPriceData` prop, adjusted `useEffect` hooks, and modified conditional rendering logic.

Possibly related PRs

Estimating points and saving them #381: Changes in Success.view.tsx regarding handling tokenPriceData are related to the modifications in the SuccessView component for cross-chain functionality.
Asserting values #382: Updates to Initial.view.tsx enhance transaction handling logic, similar to the changes made in the main PR.
fix: success view for request and claim #409: Modifications in Success.view.tsx streamline fetching destination chain data, related to enhancements in the main PR.
Routes error on request pay #413: Restructuring of Initial.view.tsx for improved state management aligns with the main PR's focus on transaction handling logic.
feat(request): pre-load requested pair on pay #432: Introduction of a new useEffect in Initial.view.tsx to pre-load requested pairs complements the main PR's transaction handling process.
fix(request): correctly identify native tokens #434: Improvements in Initial.view.tsx for identifying native tokens relate to the main PR's focus on transaction handling logic.

Suggested reviewers

Hugo0

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a44e39c and 9843fa9.

📒 Files selected for processing (2)

src/components/Request/Pay/Views/Initial.view.tsx (0 hunks)
src/components/Request/Pay/Views/Success.view.tsx (3 hunks)

💤 Files with no reviewable changes (1)

src/components/Request/Pay/Views/Initial.view.tsx

🧰 Additional context used

📓 Learnings (1)

src/components/Request/Pay/Views/Success.view.tsx (5)

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#409
File: src/components/Request/Pay/Views/Success.view.tsx:23-23
Timestamp: 2024-10-03T12:52:52.740Z
Learning: In the `SuccessView` component, `transactionHash` remains constant because we are in a success view, so it's unnecessary to include it in the dependency array of `useEffect` hooks.

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#409
File: src/components/Request/Pay/Views/Success.view.tsx:23-23
Timestamp: 2024-10-08T20:13:42.967Z
Learning: In the `SuccessView` component, `transactionHash` remains constant because we are in a success view, so it's unnecessary to include it in the dependency array of `useEffect` hooks.

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#409
File: src/components/Request/Pay/Views/Success.view.tsx:23-23
Timestamp: 2024-10-08T20:13:44.480Z
Learning: In the `SuccessView` component, `transactionHash` remains constant because we are in a success view, so it's unnecessary to include it in the dependency array of `useEffect` hooks.

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#422
File: src/components/Request/Pay/Pay.consts.ts:34-34
Timestamp: 2024-10-07T15:50:29.173Z
Learning: In `src/components/Request/Pay` components, the `tokenPrice` property in the `IPayScreenProps` interface is only relevant to these views. Other components using `IPayScreenProps` do not need to handle `tokenPriceData` when it's updated in these components.

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#422
File: src/components/Request/Pay/Pay.consts.ts:34-34
Timestamp: 2024-10-08T20:13:42.967Z
Learning: In `src/components/Request/Pay` components, the `tokenPrice` property in the `IPayScreenProps` interface is only relevant to these views. Other components using `IPayScreenProps` do not need to handle `tokenPriceData` when it's updated in these components.

🔇 Additional comments (5)

src/components/Request/Pay/Views/Success.view.tsx (5)

8-9: Imports added for 'peanut' SDK and 'useAccount' hook.

The necessary imports are correctly added for the 'peanut' SDK and the useAccount hook from wagmi.

11-13: Updated component to include 'tokenPriceData' prop and use 'isXChain' and 'address'.

The SuccessView component now correctly accepts tokenPriceData and utilizes isXChain from context and address from the useAccount hook.

24-42: Submission of request fulfillment and local storage handling within useEffect.

The useEffect hook appropriately submits the request fulfillment and saves details to local storage when explorerUrlDestChainWithTxHash is available.

44-45: Fetching destination chain data for cross-chain transactions.

The useEffect hook correctly fetches the destination chain data when isXChain is true and transactionHash is present.

Line range hint 64-80: Conditional rendering updated for cross-chain transaction details.

The conditional rendering now uses isXChain to display Axelar and destination chain transaction links, enhancing the user experience for cross-chain transactions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

src/components/Request/Pay/Views/Success.view.tsx

Hugo0 · 2024-10-14T22:26:17Z

src/components/Request/Pay/Views/Success.view.tsx

+                chainId: requestLinkData.chainId,
+                hash: explorerUrlDestChainWithTxHash.transactionId,


Question: Just so I understand this, does the requestLinkFulfillment only get submitted once the destination chain tx is through? So, if the user closes the page, it would never submit the fulfillment right?

Correct. I think the way to go around this is submit the origin transaction to the backend (but not mark as paid) and then with the destination chain tx we can do as today (if the user did not close the page) or in the backend we can check

fix(request): store correct destination hash for xchain

9843fa9

vercel bot deployed to Preview October 14, 2024 11:49 View deployment

jjramirezn requested a review from Hugo0 October 14, 2024 12:07

Hugo0 approved these changes Oct 14, 2024

View reviewed changes

Hugo0 merged commit a1daf8a into develop Oct 14, 2024

This was referenced Oct 15, 2024

fix: request pay issues #443

Merged

chore: Add additional data to already claimed links and already paid requests #441

Merged

feat(request): simpler create success screen #450

Merged

jjramirezn deleted the fix/destination-hash-on-profile branch October 16, 2024 16:35

This was referenced Oct 17, 2024

Fix/cashout status #457

Merged

[ISSUE-213] refactor: load token pair onto selector context before advancing from pay #461

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(request): store correct destination hash for xchain#437

fix(request): store correct destination hash for xchain#437
Hugo0 merged 1 commit intodevelopfrom
fix/destination-hash-on-profile

jjramirezn commented Oct 14, 2024

Uh oh!

vercel bot commented Oct 14, 2024 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 14, 2024 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Hugo0 Oct 14, 2024

Uh oh!

jjramirezn Oct 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		chainId: requestLinkData.chainId,
		hash: explorerUrlDestChainWithTxHash.transactionId,

Conversation

jjramirezn commented Oct 14, 2024

Uh oh!

vercel bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Hugo0 Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

jjramirezn Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Oct 14, 2024 •

edited

Loading

coderabbitai bot commented Oct 14, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)