[ISSUE-201] fix(token-selector): show empty message when no token match filter

[jjramirezn]

Token selector was fake loading forever if there was a wallet connected and no token matched the filter, now we show the empty list message, we no longer need to check for hasFetchedBalances because we will always have token to show (the sdk ones)

[notion-workspace]

🪲 Bug: TokenSelector loads forever on tokensearch for a not listed token if not connected

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 21, 2024 11:31pm

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request focus on the TokenSelector component, specifically modifying the TokenList component within TokenSelector.tsx. The primary update involves removing the hasFetchedBalances variable, simplifying the conditional rendering logic to rely solely on the emptiness of the balances array. Additionally, placeholder rows for displaying balances have been eliminated, leading directly to a message display when no balances are present. The overall structure and functionality of the TokenSelector component remain intact, with a streamlined user interface.

Changes

File Path	Change Summary
src/components/Global/TokenSelector/TokenSelector.tsx	Removed hasFetchedBalances variable and placeholder rows; simplified rendering logic based on balances array.

Possibly related PRs

• fix: prefered token in localStorage doesn't match any currently fetched tokens #395: Modifies the TokenSelector.tsx component to improve the logic for displaying tokens and balances.
• feat(token-selector): show default tokens for connected wallets with no balance #424: Introduces a new TokenList component within TokenSelector.tsx, enhancing the rendering of token balances.
• fix: remaining ux issues #401: Addresses user experience improvements in the TokenSelector component, allowing users to bypass balances when no account is connected.
• fix(request): allow user to connect on request pay page #449: Enhances the InitialView component, which includes the TokenSelector, by improving error handling and user feedback related to connection status.
• [ISSUE-213] refactor: load token pair onto selector context before advancing from pay #461: Refactors the token pair loading process in the context used by the TokenSelector, ensuring that the correct data is utilized.

Suggested labels

Being worked on

Suggested reviewers

• Hugo0

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cb65b74 and 0d92623.

📒 Files selected for processing (1)

• src/components/Global/TokenSelector/TokenSelector.tsx (1 hunks)

🧰 Additional context used

📓 Learnings (1)

src/components/Global/TokenSelector/TokenSelector.tsx (1)

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#424
File: src/components/Global/TokenSelector/TokenSelector.tsx:197-211
Timestamp: 2024-10-11T01:14:15.489Z
Learning: In `src/components/Global/TokenSelector/TokenSelector.tsx`, when the calculation within functions like `byChainAndText` is not computationally expensive, it's acceptable to avoid using `useCallback` for memoization.

🔇 Additional comments (1)

src/components/Global/TokenSelector/TokenSelector.tsx (1)

30-37: LGTM! Improved empty state handling and simplified logic.

The changes in this segment effectively address the PR objectives:

1. The condition for displaying the "No balances to display!" message has been simplified, now solely based on the balances array being empty.
2. Removal of the hasFetchedBalances check aligns with the guarantee that there will always be tokens available (SDK tokens).
3. Elimination of placeholder rows provides clearer feedback to users when no tokens match the filter.

These modifications enhance the user experience and streamline the component's logic.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Hugo0]

nice!

[Hugo0]

nice, i was concerned about tokenselection elements changing after api call but it's pretty quick