[TASK-6558] prevent e in token input by nezz0746 · Pull Request #491 · peanutprotocol/peanut-ui

nezz0746 · 2024-10-28T09:46:34Z

No description provided.

coderabbitai · 2024-10-28T09:46:42Z

📝 Walkthrough

Walkthrough

The changes in the TokenAmountInput component introduce a new key event handling feature that prevents the default action for the 'e', '+', and '-' keys, thereby disallowing scientific notation and certain mathematical symbols in the input. Additionally, minor adjustments were made to the rendering logic of the token amount label to ensure consistent output when the tokenValue is falsy. The overall functionality of the component remains unchanged, focusing on enhancing input validation and the display of token amounts.

Changes

File Path	Change Summary
src/components/Global/TokenAmountInput/index.tsx	Added key event handling to prevent scientific notation input and adjusted rendering logic for token amount display.

Possibly related PRs

Fix input amount #380: The changes in the InitialView component involve handling token amounts and formatting based on selected decimals, which relates to the input validation and display logic in the TokenAmountInput component.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 0852ae6 and d7eb63d.

📒 Files selected for processing (1)

src/components/Global/TokenAmountInput/index.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/Global/TokenAmountInput/index.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2024-10-28T09:46:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 2:10pm

coderabbitai

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

src/components/Global/TokenAmountInput/index.tsx (1)
81-83: LGTM! Consider adding a comment explaining the e-key prevention.

The implementation correctly prevents scientific notation input, which improves the user experience for token amount entry.

Add a comment to explain why we're preventing 'e':
+                        // Prevent scientific notation ('e' key) in numeric input
                         if (e.key.toLowerCase() === 'e') {
                             e.preventDefault()
                         }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b9e1aa2 and 8d4ead5.

📒 Files selected for processing (1)

src/components/Global/TokenAmountInput/index.tsx (2 hunks)

🔇 Additional comments (1)

src/components/Global/TokenAmountInput/index.tsx (1)

Line range hint 22-24: Verify input validation constraints.

The component handles decimal input but lacks explicit validation for:

Maximum value constraints

Decimal place limitations

Precision handling for large numbers

This could lead to potential issues with token amount calculations or display.

Let's check if there are any validation utilities or constants defined elsewhere:

Consider adding:

Maximum value validation

Decimal place constraints

Proper numeric validation using regex or validation utilities

coderabbitai · 2024-10-28T09:53:34Z

src/components/Global/TokenAmountInput/index.tsx

+                            ? '0' 
                            : inputDenomination === 'USD'
                              ? utils.formatTokenAmount(Number(tokenValue) / (selectedTokenData?.price ?? 0))
                              : '$' + utils.formatTokenAmount(Number(tokenValue) * (selectedTokenData?.price ?? 0))}


🛠️ Refactor suggestion

Consider simplifying the nested ternary expression.

While the falsy value handling is correct, the nested ternary makes the code harder to read and maintain.

Consider refactoring to improve readability:

- {!tokenValue - ? '0' - : inputDenomination === 'USD' - ? utils.formatTokenAmount(Number(tokenValue) / (selectedTokenData?.price ?? 0)) - : '$' + utils.formatTokenAmount(Number(tokenValue) * (selectedTokenData?.price ?? 0))} + {(() => { + if (!tokenValue) return '0'; + const amount = inputDenomination === 'USD' + ? Number(tokenValue) / (selectedTokenData?.price ?? 0) + : Number(tokenValue) * (selectedTokenData?.price ?? 0); + return inputDenomination === 'USD' + ? utils.formatTokenAmount(amount) + : '$' + utils.formatTokenAmount(amount); + })()}

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

? '0'

: inputDenomination === 'USD'

? utils.formatTokenAmount(Number(tokenValue) / (selectedTokenData?.price ?? 0))

: '$' + utils.formatTokenAmount(Number(tokenValue) * (selectedTokenData?.price ?? 0))}

{(() => {

if (!tokenValue) return '0';

const amount = inputDenomination === 'USD'

? Number(tokenValue) / (selectedTokenData?.price ?? 0)

: Number(tokenValue) * (selectedTokenData?.price ?? 0);

return inputDenomination === 'USD'

? utils.formatTokenAmount(amount)

: '$' + utils.formatTokenAmount(amount);

})()}

notion-workspace · 2024-10-28T09:56:29Z

🪲 Bug: token input allows non decimal input

jjramirezn

suggestion(blocking): it's a good opportunity to prevent '+' and '-' also (they are valid in decimal mode too)

jjramirezn · 2024-10-28T14:14:23Z

src/components/Global/TokenAmountInput/index.tsx

                            e.preventDefault()
                            if (onSubmit) onSubmit()
                        }
+                        if (['e', '+', '-'].includes(e.key.toLowerCase())) {


praise: nice!

vercel bot had a problem deploying to Preview October 28, 2024 09:48 Failure

coderabbitai bot reviewed Oct 28, 2024

View reviewed changes

nezz0746 changed the base branch from main to develop October 28, 2024 09:55

nezz0746 changed the title ~~fix: prevent e in token input~~ [TASK-6558] prevent e in token input Oct 28, 2024

nezz0746 force-pushed the feat/preven-e-in-token-input branch from 8d4ead5 to 2510d87 Compare October 28, 2024 10:09

vercel bot had a problem deploying to Preview October 28, 2024 10:12 Failure

nezz0746 force-pushed the feat/preven-e-in-token-input branch from 2510d87 to a78ff25 Compare October 28, 2024 10:44

vercel bot had a problem deploying to Preview October 28, 2024 10:47 Failure

fix: prevent e in token input

0852ae6

nezz0746 force-pushed the feat/preven-e-in-token-input branch from a78ff25 to 0852ae6 Compare October 28, 2024 13:29

vercel bot deployed to Preview October 28, 2024 13:32 View deployment

jjramirezn requested changes Oct 28, 2024

View reviewed changes

fix: include + & - as prohibited characters

d7eb63d

vercel bot deployed to Preview October 28, 2024 14:10 View deployment

jjramirezn approved these changes Oct 28, 2024

View reviewed changes

jjramirezn merged commit 4c626b4 into develop Oct 28, 2024

coderabbitai bot mentioned this pull request Oct 28, 2024

[TASK-6125] Feat: Peanut Wallet #464

Closed

coderabbitai bot mentioned this pull request May 15, 2025

fixes: pesos currency #854

Merged

Hugo0 deleted the feat/preven-e-in-token-input branch July 3, 2025 18:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TASK-6558] prevent e in token input#491

[TASK-6558] prevent e in token input#491
jjramirezn merged 2 commits intodevelopfrom
feat/preven-e-in-token-input

nezz0746 commented Oct 28, 2024

Uh oh!

coderabbitai bot commented Oct 28, 2024 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

vercel bot commented Oct 28, 2024 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Oct 28, 2024

Uh oh!

notion-workspace bot commented Oct 28, 2024

Uh oh!

jjramirezn left a comment

Uh oh!

jjramirezn Oct 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-                            ? '0'
-                            : inputDenomination === 'USD'
-                              ? utils.formatTokenAmount(Number(tokenValue) / (selectedTokenData?.price ?? 0))
-                              : '$' + utils.formatTokenAmount(Number(tokenValue) * (selectedTokenData?.price ?? 0))}
+                        {(() => {
+                            if (!tokenValue) return '0';
+                            const amount = inputDenomination === 'USD'
+                                ? Number(tokenValue) / (selectedTokenData?.price ?? 0)
+                                : Number(tokenValue) * (selectedTokenData?.price ?? 0);
+                            return inputDenomination === 'USD'
+                                ? utils.formatTokenAmount(amount)
+                                : '$' + utils.formatTokenAmount(amount);
+                        })()}

Conversation

nezz0746 commented Oct 28, 2024

Uh oh!

coderabbitai bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

vercel bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

notion-workspace bot commented Oct 28, 2024

Uh oh!

jjramirezn left a comment

Choose a reason for hiding this comment

Uh oh!

jjramirezn Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Oct 28, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

vercel bot commented Oct 28, 2024 •

edited

Loading