[TASK-6450] add register/login functions in setup flow & home page by nezz0746 · Pull Request #501 · peanutprotocol/peanut-ui

nezz0746 · 2024-10-30T17:05:54Z

Changes

Calling register in setup to create passkey in format {handle}.peanut.wallet
Calling handleLogin in homepage to have kernelClient be current connected client
Small type fixes
UI work on homepage

vercel · 2024-10-30T17:05:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	❌ Failed (Inspect)			Oct 31, 2024 4:40pm

coderabbitai · 2024-10-30T17:06:00Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (5)

develop
staging
dev
prod
experimental

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

notion-workspace · 2024-10-30T17:06:03Z

Register call on Setup flow

panosfilianos

Overall great PR. Very partial about the walletContext.ts but I think it's a major improvement. Let's get these things answered and let's merge.

panosfilianos · 2024-10-31T16:06:10Z

src/app/(mobile-ui)/home/page.tsx

-            }
-        }
+    const handleCardClick = (index: number) => {
+        setSelectedWallet(wallets[index])


issue (non-blocking): we need to add logic around this selection for BYOW (eg. the provider is not connected to the right wallet)

for connection status, kernelClient (PW) & wagmi context (BYOB) hold the source of truth so shouldn't mater when doing this selection. You can select a non connected wallet.

panosfilianos · 2024-10-31T16:07:19Z

src/components/0_Bruddle/Toast.tsx

+  id: number;
+}
+
+interface ToastContextType {


thought: ideally these would go to a .consts file

Tbh If it's not a large amount of code, I usually keep non exported types & interfaces in the file they're used, keeps branching & reading easier. But will not die on that hill.

panosfilianos · 2024-10-31T16:09:00Z

src/components/Setup/Setup.helpers.ts

+/**
+ * TEMPORARY: This is a temporary storage solution for storing passkeys locally to move forward with UI development.
+ */
+export class PasskeyStorage {


question: do we expect to delete this file?

Hopefully, once we replaced it with backend accounts

panosfilianos · 2024-10-31T16:09:49Z

src/components/Setup/Views/Handle.provider.view.tsx

question: it seems like we should delete this file. Am I missing something?

Was trying go straight to feature here, updated what was needed. But kept as is in case you wanted to use.

panosfilianos · 2024-10-31T16:10:20Z

src/components/Setup/Views/Welcome.tsx

        })
    }

+    const businessLogic = async () => {


thought: this should probably be renamed

panosfilianos · 2024-10-31T16:11:18Z

src/context/authContext.tsx

-            setupWalletsAfterLogin()
-        }
-    }, [kernelClientAddress, isKernelClientReady])
-


note: my upcoming PR will introduce similar functionality

panosfilianos · 2024-10-31T16:13:45Z

src/context/walletContext/walletContext.tsx

-    //      - wagmi not connected
-    //      - wagmi connected to wrong wallet
-    // throws WalletError in case of error which is an 'undefined' return
-    const checkActivateWallet = async (wallet: interfaces.IWallet): Promise<interfaces.IWallet | undefined> => {


issue (non-blocking): this is the functionality we need for BYOWs. wdyt?

I think here you couldn't select as active if it wasn't connected. I've unlocked this possibility & let users select the wallet they want, and sign in in a second time.

nezz0746 added 11 commits October 31, 2024 08:53

feat: add bruddle toad component & context

b006109

feat: update setupflow handlenext business logic

d3dc77a

refactor: remove email signin

8059a46

fix: mock check validity in welcome setup

e278692

refactor: zerodev context type & handleLogin error handling

8d2d966

style: add green button variant

7686efe

feat: add temporary local passkey account store

3ce820e

feat: display registered accounts on homepage

96bf8ea

fix: build error userop args

fa0d01e

style: show empty card

2a20fdc

feat: setup selected wallet in wallet context

f0a0549

nezz0746 added the Being worked on Being worked on label Oct 31, 2024

nezz0746 force-pushed the feat/setup-flow-w-passkey branch from 3b87a79 to f0a0549 Compare October 31, 2024 12:02

vercel bot had a problem deploying to Preview October 31, 2024 12:06 Failure

fix: feed the correct connection status to the selectedWallet object

35065bd

vercel bot had a problem deploying to Preview October 31, 2024 14:45 Failure

style: homepage no-pw/connected wallets ui

de95b1c

vercel bot had a problem deploying to Preview October 31, 2024 15:26 Failure

nezz0746 removed the Being worked on Being worked on label Oct 31, 2024

panosfilianos reviewed Oct 31, 2024

View reviewed changes

fix: rename setup flow method names

fbede0a

vercel bot had a problem deploying to Preview October 31, 2024 16:40 Failure

nezz0746 merged commit a2601c6 into peanut-wallet Oct 31, 2024

Hugo0 deleted the feat/setup-flow-w-passkey branch July 3, 2025 18:22

Conversation

nezz0746 commented Oct 30, 2024

Changes

Uh oh!

vercel bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 30, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

notion-workspace bot commented Oct 30, 2024

Uh oh!

panosfilianos left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Oct 30, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)