Skip to content

feat: Fetch wallets from accounts#509

Merged
jjramirezn merged 11 commits intopeanut-walletfrom
feat/add-get-wallets
Nov 8, 2024
Merged

feat: Fetch wallets from accounts#509
jjramirezn merged 11 commits intopeanut-walletfrom
feat/add-get-wallets

Conversation

@panosfilianos
Copy link
Copy Markdown
Contributor

@panosfilianos panosfilianos commented Nov 4, 2024

Adds

  • Logic to properly auth after register (note: does not work on reload)
  • Logic to add PW to user accounts
  • Logic to get wallets from accounts (refreshes on user.accounts refresh)
  • AccountType from backend to frontend
  • ChainType newly created here
  • Update Account type with chain and AccountType

Removes

  • handle from IWallet (using user.user.username from useAuth() context)

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
peanut-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 3:18pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 4, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (5)
  • develop
  • staging
  • dev
  • prod
  • experimental

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

address: account.account_identifier,
connected: false
}))
return processedWallets ? processedWallets : []
Copy link
Copy Markdown
Contributor

@nezz0746 nezz0746 Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questions:

  • Can we keep kernelClientAddress as to be non-breaking to current flow ? (Also maybe merge both localStorage accounts & fetched ones in the response)
  • Does account.account_type is the same type as walletProviderType ?
  • Is handle missing ?

Maybe we can store this PR until we get the right data into the account type ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions to make sure I understand:

  1. Can you explain a bit deeper on how kernelClientAddress is influencing this? My understanding is that that wallets should be populated only when the user accounts are populated/ depopulated (auth/logout). Happy to hop on a call to solve this quickly.
  2. Correct me if I'm wrong but i think the user will be fetched every time the page is reloaded and the accounts will be populated. The same way we cleared walletContext and decided to have single sources of truth, I think the best idea here would be to have a single source of truth via user.accounts. Additionally, when a new BYOW is added we add to DB and user.accounts. Wdyt?
  3. That's the expectation with account.account_type
  4. I have not included it (don't see the need to). Wdyt?

Copy link
Copy Markdown
Contributor

@nezz0746 nezz0746 Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for late reply !

  • Yes kernelClientAddress was just to update that query when someone registered a new wallet and got redirected to home screen.
  • I see it's been added, perfect
  • Will need it to be displayed in the profile, but we can grab this from the user probably since for now it's one to one relationship with PWs

@jjramirezn jjramirezn merged commit cbb8e42 into peanut-wallet Nov 8, 2024
@Hugo0 Hugo0 deleted the feat/add-get-wallets branch July 3, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants