[TASK-6753] feat: check username availability#515
Conversation
jjramirezn
commented
Nov 5, 2024
- Add a HEAD proxy passthrough (api url in client side is not standarized, maybe we should add a PUBLIC env variable, still proxy endpoint is useful)
- Check for username availability in setup
- Use bruddle component in ValidatedInput
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (5)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
panosfilianos
left a comment
There was a problem hiding this comment.
Neat, short PR.
Check my thought below. If you want, push a fix. Otherwise fft merge.
| method: 'HEAD', // we only need the status code no body | ||
| }) | ||
| // 404 on user means no user exist with this handle | ||
| const isHandleTaken = 404 !== res.status |
There was a problem hiding this comment.
thought (def non-blocking): I think this check should test for 404 not if it is not 404. The idea here is that in the future we may do any number of things in the api-ts and we may end up with other error codes (eg. 429s or 500 in case of our error etc.)
based on the above we'd have a handle taken result which wouldn't be accurate.