fix: passkey & setup layout fixes by nezz0746 · Pull Request #520 · peanutprotocol/peanut-ui

nezz0746 · 2024-11-08T10:10:23Z

Changes

added correct passkey setupscreen assets
fixed setup layout bug on desktop
re centered profile header user pfp

vercel · 2024-11-08T10:10:27Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 8, 2024 10:10am

coderabbitai · 2024-11-08T10:10:32Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (5)

develop
staging
dev
prod
experimental

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

jjramirezn · 2024-11-08T11:46:42Z

src/components/Home/HomeHeader.tsx

+                    />
+                </div>
+                <div className="">
+                    <p>www.peanute.me/</p>


issue(blocking): typo on peanut.me url

jjramirezn · 2024-11-08T11:59:50Z

src/app/(setup)/setup/page.tsx

    return (
-        <div className={twMerge('flex h-screen flex-col bg-opacity-100 p-6 transition-all', step.containerClassname)}>
+        <div className={twMerge('flex h-full flex-col bg-opacity-100 p-6 transition-all', step.containerClassname)}>
            <div className="mg:1/3 mx-auto flex h-full w-full flex-col gap-8 md:w-1/2 lg:gap-12">


issue (non-blocking, you decide): for small screens handle confirmation is partially hidden

I mark as non-blocking because it was not introduced in this PR, but as we are around we can tackle it now. Either fix it or create a task

Bummer, I don't have such a large crush on IPhone SE but still text is cut a little bit yeah. Fixed this on the welcome screen will fix here

jjramirezn · 2024-11-08T12:02:26Z

src/app/(mobile-ui)/home/page.tsx

-                            </div>
-                        )}
-                    </div>
+                    <HomeHeader />


praise: this is the way

nezz0746 added 4 commits November 8, 2024 08:37

add correct passkey fingerprint image to setup

a5ba029

fix: desktop setup layout & add correct passkey images

4364d45

refactor: HomeHeader

5a4c3b6

fix: center pfp icon & name on home

d642b4f

jjramirezn self-requested a review November 8, 2024 11:32

jjramirezn requested changes Nov 8, 2024

View reviewed changes

jjramirezn reviewed Nov 8, 2024

View reviewed changes

nezz0746 merged commit b183f62 into peanut-wallet Nov 8, 2024

Hugo0 deleted the fix/replace-wrong-assets branch July 3, 2025 18:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: passkey & setup layout fixes#520

fix: passkey & setup layout fixes#520
nezz0746 merged 4 commits intopeanut-walletfrom
fix/replace-wrong-assets

nezz0746 commented Nov 8, 2024

Uh oh!

vercel bot commented Nov 8, 2024

Uh oh!

coderabbitai bot commented Nov 8, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

jjramirezn Nov 8, 2024

Uh oh!

jjramirezn Nov 8, 2024

Uh oh!

nezz0746 Nov 8, 2024

Uh oh!

jjramirezn Nov 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nezz0746 commented Nov 8, 2024

Changes

Uh oh!

vercel bot commented Nov 8, 2024

Uh oh!

coderabbitai bot commented Nov 8, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

jjramirezn Nov 8, 2024

Choose a reason for hiding this comment

Uh oh!

jjramirezn Nov 8, 2024

Choose a reason for hiding this comment

Uh oh!

nezz0746 Nov 8, 2024

Choose a reason for hiding this comment

Uh oh!

jjramirezn Nov 8, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)