Skip to content

[TASK-7742] update: merge t&c and privacy links in footer#584

Merged
Hugo0 merged 1 commit intodevelopfrom
fix/footer-links
Dec 22, 2024
Merged

[TASK-7742] update: merge t&c and privacy links in footer#584
Hugo0 merged 1 commit intodevelopfrom
fix/footer-links

Conversation

@kushagrasarathe
Copy link
Copy Markdown
Contributor

@kushagrasarathe kushagrasarathe commented Dec 20, 2024

  • merge the terms and privacy link in footer

Summary by CodeRabbit

  • New Features
    • Updated footer links to consolidate "Privacy" and "Terms" into a single entry titled "Privacy & T&Cs" with a new URL.

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
peanut-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 11:23am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 20, 2024

Walkthrough

The pull request updates the footer links in the application by consolidating the separate "Privacy" and "Terms" links into a single "Privacy & T&Cs" link. The new link points to a Notion page that contains both the Terms of Service and Privacy Policy, simplifying the footer navigation and centralizing these important legal documents.

Changes

File Change Summary
src/components/Global/Footer/consts.ts Replaced separate "Privacy" and "Terms" links with a single "Privacy & T&Cs" link pointing to a Notion page

Possibly related PRs

Suggested reviewers

  • Hugo0

Poem

🐰 Hop, hop, through the footer's new design,
Legal links now streamlined and fine!
Privacy and Terms, once two, now one,
A rabbit's leap of clarity has begun! 📄✨

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/components/Global/Footer/consts.ts (1)

36-37: Consider URL improvements for better reliability.

A few suggestions to enhance the implementation:

  1. Consider removing the pvs=4 query parameter if it's not essential
  2. Consider hosting these documents on your own domain for better control and reliability
  3. Add error handling in the UI component in case the Notion page is inaccessible

Example implementation:

 {
     name: 'Privacy & T&Cs',
-    url: 'https://peanutprotocol.notion.site/Terms-of-Service-Privacy-Policy-1f245331837f4b7e860261be8374cc3a?pvs=4',
+    url: 'https://peanutprotocol.notion.site/Terms-of-Service-Privacy-Policy-1f245331837f4b7e860261be8374cc3a',
 }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8cd19c and 53fbebb.

📒 Files selected for processing (1)
  • src/components/Global/Footer/consts.ts (1 hunks)
🔇 Additional comments (1)
src/components/Global/Footer/consts.ts (1)

36-37: LGTM! Good UX improvement.

Consolidating the Privacy and Terms links into a single entry simplifies the footer navigation while maintaining access to both documents.

@kushagrasarathe kushagrasarathe changed the title fix: merge t&c and privacy links in footer [TASK-7742] update: merge t&c and privacy links in footer Dec 20, 2024
@notion-workspace
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@Hugo0 Hugo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants