Skip to content

[TASK-7729] fix: remove allowedDomains from safe connector#586

Merged
Hugo0 merged 1 commit intodevelopfrom
fix/safe-connector
Dec 27, 2024
Merged

[TASK-7729] fix: remove allowedDomains from safe connector#586
Hugo0 merged 1 commit intodevelopfrom
fix/safe-connector

Conversation

@kushagrasarathe
Copy link
Copy Markdown
Contributor

@kushagrasarathe kushagrasarathe commented Dec 20, 2024

  • fixed the safe wallet connection issue by removing allowedDomains configuration from safe-connector

Summary by CodeRabbit

  • New Features

    • Simplified domain restrictions for the safe connector, potentially broadening its applicability.
  • Bug Fixes

    • Removed the regex pattern that matched intersend.io from the allowedDomains property.

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
peanut-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 3:07pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 20, 2024

Walkthrough

The pull request modifies the src/config/wagmi.config.tsx file, specifically focusing on the safe connector configuration. The key change involves removing the allowedDomains property that previously restricted the connector to intersend.io domains. This alteration simplifies the domain restrictions for the safe connector, potentially expanding its usability across different domains while maintaining the overall structure and functionality of the configuration.

Changes

File Change Summary
src/config/wagmi.config.tsx Removed allowedDomains regex pattern for intersend.io from the safe connector configuration

Possibly related PRs

Suggested reviewers

  • jjramirezn

Poem

🐰 A Wagmi Config Hop 🌐

Domains once restricted, now set free,
Safe connector leaps with glee,
No more intersend.io in sight,
Configurations taking flight,
A rabbit's config dance so light! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8cd19c and a6a98d2.

📒 Files selected for processing (1)
  • src/config/wagmi.config.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • src/config/wagmi.config.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kushagrasarathe kushagrasarathe changed the title fix: remove allowedDomains from safe connector [TASK-7729] fix: remove allowedDomains from safe connector Dec 20, 2024
@kushagrasarathe kushagrasarathe marked this pull request as ready for review December 20, 2024 15:18
@notion-workspace
Copy link
Copy Markdown

@Hugo0 Hugo0 merged commit fea6cc0 into develop Dec 27, 2024
@Hugo0 Hugo0 deleted the fix/safe-connector branch July 3, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants