[TASK-7465] + [TASK-7458] : home screen cards by kushagrasarathe · Pull Request #589 · peanutprotocol/peanut-ui

kushagrasarathe · 2024-12-27T09:55:24Z

update wallet cards to match new design
add toggle wallet balance functionality
fetch get wallet icon

@Hugo0 side note, the base branch for this pr is the registration-flow branch since main was already merged in it

vercel · 2024-12-27T09:55:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 27, 2024 6:01pm

coderabbitai · 2024-12-27T09:55:31Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (7)

peanut-wallet
main
develop
staging
legacy
wallet
peanut-me

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

notion-workspace · 2024-12-27T09:55:32Z

Implement Home Screen Cards

notion-workspace · 2024-12-27T09:55:32Z

Pull Wallet Icon from reown

Hugo0

Overall lg! But needs some minor changes

Hugo0 · 2024-12-27T13:36:11Z

src/app/(mobile-ui)/home/page.tsx

 const cardWidth = 300
 const cardMargin = 16

+const BALANCE_VISIBILITY_KEY = 'peanut-balance-visibility'


nit, blocking: this seems like wrong place to define this - check out updatePeanutPreferences.

We should have all user preferences together, not separate in various files or various localstorage keys

my bad, missed this one, gonna fix it 🫡

src/app/(mobile-ui)/home/page.tsx

Hugo0 · 2024-12-27T13:36:51Z

src/app/(mobile-ui)/home/page.tsx


+    // hide balance
+    const handleToggleBalanceVisibility = (e: React.MouseEvent<HTMLButtonElement>) => {
+        e.stopPropagation()


Q: What is e.stopPropagation for here?

@Hugo0 added this to prevent bubbling, if you clicked on the hide button, it would take you to the respective wallet page, which shouldn't happen as all I wanted was to hide the balance, so to prevent that from happening, I added this stopPropagation method

src/app/(mobile-ui)/home/page.tsx

src/components/Global/CopyToClipboard/index.tsx

src/components/Home/WalletCard.tsx

Hugo0 · 2024-12-27T13:39:44Z

src/components/Home/WalletCard.tsx

            <motion.div className="h-full">
                <Card
-                    className="h-full min-w-[300px] rounded-md text-black hover:cursor-pointer"
+                    className="h-full min-w-[300px] rounded-xl bg-purple-4/20 text-black hover:cursor-pointer"


thought: we prob should rename our colors to primary, secondary etc

@Hugo0 agreed, for this my suggestion would be to fix all the colors separately, after certain features are done. This is a small task but will need some time. Happy to tackle this on another spirint :)

src/context/walletContext/walletContext.tsx

kushagrasarathe requested a review from Hugo0 December 27, 2024 09:55

vercel bot deployed to Preview December 27, 2024 09:58 View deployment

vercel bot deployed to Preview December 27, 2024 10:13 View deployment

Hugo0 requested changes Dec 27, 2024

View reviewed changes

kushagrasarathe force-pushed the feat/registration-flow branch from d94b582 to 191d256 Compare December 27, 2024 16:00

kushagrasarathe changed the base branch from feat/registration-flow to peanut-wallet December 27, 2024 16:18

kushagrasarathe changed the base branch from peanut-wallet to feat/registration-flow December 27, 2024 16:18

kushagrasarathe added 2 commits December 27, 2024 21:55

feat: update wallet card ui + fetch wallet icon

0595eec

fix: formatting

291fe4e

kushagrasarathe force-pushed the feat/wallet-cards branch from d3a4afe to 291fe4e Compare December 27, 2024 16:26

vercel bot deployed to Preview December 27, 2024 16:32 View deployment

fix: pr review changes + update clipboard component

a94a9d7

kushagrasarathe requested a review from Hugo0 December 27, 2024 17:51

vercel bot had a problem deploying to Preview December 27, 2024 17:54 Failure

fix: push localstorage key

f01fc99

vercel bot deployed to Preview December 27, 2024 18:01 View deployment

Hugo0 approved these changes Dec 30, 2024

View reviewed changes

Hugo0 merged commit f8ec8a6 into feat/registration-flow Dec 30, 2024

Hugo0 deleted the feat/wallet-cards branch July 3, 2025 18:23

Conversation

kushagrasarathe commented Dec 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Dec 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Dec 27, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

notion-workspace bot commented Dec 27, 2024

Uh oh!

notion-workspace bot commented Dec 27, 2024

Uh oh!

Hugo0 left a comment

Choose a reason for hiding this comment

Uh oh!

Hugo0 Dec 27, 2024

Choose a reason for hiding this comment

Uh oh!

kushagrasarathe Dec 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Hugo0 Dec 27, 2024

Choose a reason for hiding this comment

Uh oh!

kushagrasarathe Dec 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hugo0 Dec 27, 2024

Choose a reason for hiding this comment

Uh oh!

kushagrasarathe Dec 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kushagrasarathe commented Dec 27, 2024 •

edited

Loading

vercel bot commented Dec 27, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)