fix: disco bug when logging out

[kushagrasarathe]

• also removes connected status from home page as per TASK-8183
• added reset setup state to reset to signup/login view when logging out

fixes TASK-8304
fixes TASK-8183

Summary by CodeRabbit

• Refactor
  • Removed a temporary sign-in option from the mobile home screen for a streamlined interface.
  • Updated the onboarding flow to navigate to the main section only after confirming a valid user session.
  • Enhanced logout behavior to reset the app’s setup, ensuring a smoother return to the initial configuration.
  • Added functionality to reset state properties during logout for improved user experience.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 3, 2025 5:28pm

[coderabbitai]

Walkthrough

The changes remove a temporary sign-in button from the mobile Home component and update the logic in the Welcome view to navigate only when a valid user is present along with the kernel being ready. Additionally, the logout mechanism in the Auth context now resets Redux state via a new reducer before navigating to the setup page. These adjustments streamline the UI and ensure that authentication state is handled consistently across components.

Changes

File Path(s)	Change Summary
src/app/(mobile-ui)/home/page.tsx	Removed the temporary Sign-In button and its corresponding login logic; retains the LogoutButton in the mobile view.
src/components/Setup/Views/Welcome.tsx	Added useAuth hook to retrieve the user object; updated useEffect to also check for a valid user along with the kernel readiness before navigating to /home.
src/context/authContext.tsx and src/redux/slices/setup-slice.ts	Modified logout flow to include resetting Redux state by dispatching the new resetSetup reducer, then replacing the route to /setup instead of pushing it.

Possibly related PRs

• [TASK-7269] feat: login button on setup #554: The changes in the main PR, which involve the removal of a sign-in button from the Home component, relate to the modifications enhancing the login functionality in the Welcome component.
• feat: add logout feature + fix layout #641: The changes in the main PR, which involve the removal of a sign-in button from the Home component, relate to the modifications introducing a LogoutButton in the same Home component.

Suggested reviewers

• Hugo0

Poem

I'm a rabbit with a coding flair,
Hoping changes hop smoothly through the air,
Buttons removed, logic refined,
Redux resets keep our state aligned,
With every leap, our code gets brighter—
A hoppy merge, making futures lighter!
🐇💻

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37e8fe7 and 31f75bd.

📒 Files selected for processing (1)

• src/app/(mobile-ui)/home/page.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/app/(mobile-ui)/home/page.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[notion-workspace]

🪲 Bug: disco feature?

[notion-workspace]

⚙️ Issue: Remove “connected” from Homepage

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/context/authContext.tsx (1)

315-315: Remove console.log statement.

Remove the debug console.log statement before deploying to production.

-    console.log({ user })

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd9af54 and 37e8fe7.

📒 Files selected for processing (4)

• src/app/(mobile-ui)/home/page.tsx (1 hunks)
• src/components/Setup/Views/Welcome.tsx (2 hunks)
• src/context/authContext.tsx (3 hunks)
• src/redux/slices/setup-slice.ts (1 hunks)

🔇 Additional comments (6)

src/components/Setup/Views/Welcome.tsx (2)

3-3: LGTM! Added user authentication check.

The addition of the useAuth hook and user state helps prevent premature navigation.

Also applies to: 12-12

---

16-20: LGTM! Enhanced navigation guard.

The updated condition ensures navigation only occurs when both the user is authenticated and the kernel client is ready, preventing potential race conditions.

src/redux/slices/setup-slice.ts (1)

21-27: LGTM! Comprehensive state reset implementation.

The resetSetup reducer properly resets all state properties to their initial values, ensuring a clean slate after logout.

src/app/(mobile-ui)/home/page.tsx (1)

134-137: LGTM! Simplified mobile view.

The removal of the connected status and sign-in button while retaining the logout functionality aligns with the PR objectives and simplifies the mobile UI.

src/context/authContext.tsx (2)

4-5: LGTM! Added Redux integration.

The addition of Redux dispatch and setup actions enables proper state management during logout.

---

284-286: LGTM! Enhanced logout flow.

The changes improve the logout flow by:

1. Resetting setup state before navigation
2. Using router.replace instead of push to prevent back navigation to authenticated state