fix: error handling by kushagrasarathe · Pull Request #660 · peanutprotocol/peanut-ui

kushagrasarathe · 2025-02-04T09:44:18Z

fixes TASK-8583 : when no native gas token to complete tx
fixes TASK-8593 : when tx amount exceeds wallet balance

Summary by CodeRabbit

Bug Fixes
- Revised error messaging to offer clearer and more direct notifications during transactions. Users will now receive straightforward alerts for situations like insufficient funds, gas fee challenges, and network mismatches.
Refactor
- Streamlined wallet handling and network selection processes, ensuring a smoother and more reliable transaction experience.

- when no native gas token to complete tx - when tx amount exceeds wallet balance - also fixes network switching error

coderabbitai · 2025-02-04T09:44:27Z

Walkthrough

The changes update user-facing error messages and refine wallet handling logic. In the UI component for link creation, an error message is simplified. The payment view removes the unused wallet property to streamline state management. In the wallet hook, a new variable is introduced and the chain determination is updated to conditionally use a specific chain for Peanut wallets. Lastly, the SDK error handler now checks for additional error conditions and returns clearer feedback on gas fee, balance, and network mismatches.

Changes

Files	Summary
src/components/Create/Link/Input.view.tsx, src/utils/sdkErrorHandler.utils.tsx	Error Message Updates: Simplified the insufficient balance message in the input view; refined error handling logic in the SDK error handler by adding conditions for gas fee errors, balance issues, and chain mismatches.
src/components/Request/Pay/Views/Initial.view.tsx, src/hooks/wallet/useWallet.ts	Wallet Logic Enhancements: Removed the unused `selectedWallet` from the payment view and updated the wallet hook by introducing `wagmiChain` along with conditional logic for returning either `PEANUT_WALLET_CHAIN` or `wagmiChain`.

Sequence Diagram(s)

sequenceDiagram
    participant C as Component
    participant W as useWallet Hook
    participant A as useAccount Hook

    C->>W: Invoke useWallet()
    W->>A: Retrieve account and chain info (wagmiChain)
    W-->>C: Return wallet object with chain = (isPeanut? PEANUT_WALLET_CHAIN : wagmiChain)

sequenceDiagram
    participant T as Transaction Component
    participant E as ErrorHandler
    participant U as User

    T->>E: Pass error object
    E->>E: Check error conditions (e.g., fee error, chain mismatch)
    E-->>T: Return appropriate error message
    T->>U: Display error message

Possibly related PRs

fix: error state when amount exceed wallet balance #649: Revises error messages for insufficient balance and addresses similar logic in error handling, making it highly relevant to the current changes.

Suggested reviewers

jjramirezn

Poem

I'm a rabbit, hopping through the code,
With clear messages shining on every node.
Errors tamed and wallets aligned so neat,
Each change a hop, light on my feet.
Celebrating progress in a joyful, bouncing beat!
🐰💻

Tip

🌐 Web search-backed reviews and chat

We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
You can disable this feature by setting web_search: false in the knowledge_base settings.
Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6918676 and c574423.

📒 Files selected for processing (4)

src/components/Create/Link/Input.view.tsx (2 hunks)
src/components/Request/Pay/Views/Initial.view.tsx (1 hunks)
src/hooks/wallet/useWallet.ts (2 hunks)
src/utils/sdkErrorHandler.utils.tsx (2 hunks)

✅ Files skipped from review due to trivial changes (1)

src/components/Create/Link/Input.view.tsx

🔇 Additional comments (5)

src/utils/sdkErrorHandler.utils.tsx (2)

66-69: Improved error message for gas fee issues.

The error handling now covers additional gas-related error cases and provides a clearer message about needing native tokens for gas fees.

107-109: Enhanced error handling for balance and network issues.

Good improvements:

Simplified the insufficient balance message to be more user-friendly

Added handling for network mismatch errors with clear instructions

src/hooks/wallet/useWallet.ts (2)

47-47: Added wagmiChain for better chain handling.

Good addition of the wagmiChain variable from useAccount hook to support the enhanced chain determination logic.

234-234: Improved chain determination logic.

The chain property now correctly determines the chain based on wallet type:

Uses PEANUT_WALLET_CHAIN for Peanut wallets

Uses wagmiChain for external wallets

src/components/Request/Pay/Views/Initial.view.tsx (1)

84-84: Simplified wallet hook usage.

Good cleanup: Removed unused selectedWallet from useWallet hook destructuring while maintaining all necessary properties.

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2025-02-04T09:44:27Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 4, 2025 9:54am

notion-workspace · 2025-02-04T09:44:49Z

🪲 Bug: Message error for Insufficient Balance to cover fees is not clear

notion-workspace · 2025-02-04T09:44:49Z

🪲 Bug: Can’t pay a Peanut wallet request with usdc on Optimism

notion-workspace · 2025-02-04T09:44:50Z

🪲 Bug: cant fulfill

fix: error handling

c574423

- when no native gas token to complete tx - when tx amount exceeds wallet balance - also fixes network switching error

revert: use wallet changes

890205e

vercel bot deployed to Preview – peanut-ui February 4, 2025 09:54 View deployment

kushagrasarathe requested a review from jjramirezn February 4, 2025 09:55

jjramirezn approved these changes Feb 4, 2025

View reviewed changes

jjramirezn merged commit bb0fbb0 into peanut-wallet Feb 4, 2025

jjramirezn deleted the fix/error-handling branch February 4, 2025 18:48

coderabbitai bot mentioned this pull request Feb 11, 2025

fix: sending funds using native tokens fails with error, even wen enough balance #679

Merged

coderabbitai bot mentioned this pull request Feb 19, 2025

feat : req v2 ui and integrations #669

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: error handling#660

fix: error handling#660
jjramirezn merged 2 commits intopeanut-walletfrom
fix/error-handling

kushagrasarathe commented Feb 4, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

vercel bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

notion-workspace bot commented Feb 4, 2025

Uh oh!

notion-workspace bot commented Feb 4, 2025

Uh oh!

notion-workspace bot commented Feb 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kushagrasarathe commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

vercel bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

notion-workspace bot commented Feb 4, 2025

Uh oh!

notion-workspace bot commented Feb 4, 2025

Uh oh!

notion-workspace bot commented Feb 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kushagrasarathe commented Feb 4, 2025 •

edited

Loading

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

vercel bot commented Feb 4, 2025 •

edited

Loading