fix: network switching error when trying to pay a req by kushagrasarathe · Pull Request #661 · peanutprotocol/peanut-ui

kushagrasarathe · 2025-02-04T09:54:43Z

fixes TASK-8547 : network switching error

Summary by CodeRabbit

New Features
- Enhanced wallet connectivity: The system now dynamically selects the appropriate network based on the connected wallet type, ensuring that users are automatically directed to the correct blockchain network. This update improves overall wallet management, providing a more seamless and reliable experience when switching between different wallet options.

notion-workspace · 2025-02-04T09:54:49Z

vercel · 2025-02-04T09:54:49Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 4, 2025 10:00am

coderabbitai · 2025-02-04T09:54:53Z

Walkthrough

The pull request updates the wallet hook in src/hooks/wallet/useWallet.ts. It introduces a new variable, wagmiChain, taken from the useAccount hook. The change updates the chain property in the returned object to conditionally choose between PEANUT_WALLET_CHAIN when the selected wallet is a Peanut wallet, and wagmiChain otherwise. This modification dynamically adjusts the wallet management logic based on the wallet type being used.

Changes

File	Change Summary
src/hooks/wallet/useWallet.ts	Added variable `wagmiChain` from `useAccount`; updated `chain` property to use conditional assignment: `isPeanut(selectedWallet) ? PEANUT_WALLET_CHAIN : wagmiChain`

Sequence Diagram(s)

sequenceDiagram
    participant C as Component
    participant W as useWallet Hook
    participant U as useAccount Hook

    C->>W: Request wallet info
    W->>U: Call useAccount
    U-->>W: Return { wagmiChain, ... }
    alt Selected wallet is Peanut
        W->>W: Set chain = PEANUT_WALLET_CHAIN
    else
        W->>W: Set chain = wagmiChain
    end
    W-->>C: Return wallet object with chain property

Possibly related PRs

fix: req pay for guest flow #655: Adjustments in the wallet hook's return structure relate to changes in Initial.view.tsx for improved wallet handling.
fix: render token details for peanut wallet #653: Involves similar modifications around the Peanut wallet management with new variables and logic impacting wallet functionality.

Suggested reviewers

jjramirezn

Poem

I'm just a bunny with hops so fleet,
Coding away with each little beat.
New chains in place, our wallet's so neat,
Peanut or not, the logic’s complete.
Hop, skip, and code—oh, what a treat! 🥕🐇

Tip

🌐 Web search-backed reviews and chat

We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
You can disable this feature by setting web_search: false in the knowledge_base settings.
Please share any feedback in the Discord discussion.

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/hooks/wallet/useWallet.ts (1)

234-234: LGTM: Fixed network switching by implementing proper chain selection.

The conditional chain selection correctly handles both Peanut and external wallets, resolving the network switching error during payment requests.

This change improves wallet interoperability by:

Using a fixed chain for Peanut wallets

Respecting the connected chain for external wallets

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6918676 and bf805f6.

📒 Files selected for processing (1)

src/hooks/wallet/useWallet.ts (2 hunks)

🔇 Additional comments (1)

src/hooks/wallet/useWallet.ts (1)

47-47: LGTM: Correctly added wagmiChain from useAccount hook.

The addition of wagmiChain is necessary for proper network handling and follows the established naming pattern.

Hugo0

Good catch, oversight bug. I think useWallet would benefit from a docstring

fix: network switching error when trying to pay a req

bf805f6

kushagrasarathe requested a review from Hugo0 February 4, 2025 09:54

coderabbitai bot reviewed Feb 4, 2025

View reviewed changes

vercel bot deployed to Preview – peanut-ui February 4, 2025 10:00 View deployment

Hugo0 approved these changes Feb 5, 2025

View reviewed changes

Hugo0 merged commit d6d12d2 into peanut-wallet Feb 5, 2025

This was referenced Feb 11, 2025

fix: show message for peanut wallet xchain txs #683

Merged

fix: claim flow state updates lead to claiming funds on xChain in peanut wallet #689

Merged

coderabbitai bot mentioned this pull request Mar 28, 2025

fix: smart wallet payments for when a connected external wallet has diff #782

Merged

Hugo0 deleted the fix/network-switch branch July 3, 2025 18:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: network switching error when trying to pay a req#661

fix: network switching error when trying to pay a req#661
Hugo0 merged 1 commit intopeanut-walletfrom
fix/network-switch

kushagrasarathe commented Feb 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

notion-workspace bot commented Feb 4, 2025

Uh oh!

vercel bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Hugo0 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kushagrasarathe commented Feb 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

notion-workspace bot commented Feb 4, 2025

Uh oh!

vercel bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Hugo0 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kushagrasarathe commented Feb 4, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Feb 4, 2025 •

edited

Loading

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)