Skip to content

Pw to dev#674

Merged
jjramirezn merged 5 commits intopeanut-wallet-devfrom
pw-to-dev
Feb 7, 2025
Merged

Pw to dev#674
jjramirezn merged 5 commits intopeanut-wallet-devfrom
pw-to-dev

Conversation

@jjramirezn
Copy link
Copy Markdown
Contributor

@jjramirezn jjramirezn commented Feb 7, 2025

Summary by CodeRabbit

  • New Features
    • Enhanced ENS name validation across the application, ensuring recipient names and wallet addresses are accurately displayed.
    • Improved display logic now prioritizes primary names over raw wallet addresses throughout user interfaces.
    • Integrated a new blockchain connectivity context to support streamlined wallet and ENS name resolution.
    • Added new dependencies that support these improvements, leading to a more reliable and consistent user experience.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
peanut-ui 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:10pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several changes across configuration, dependency management, utility functions, and UI components. The .gitignore file is updated to correct duplicate entries and add IDE-specific ignores. New dependencies are included in package.json. Multiple components now use an improved ENS name validation via a new utility function, validateEnsName, replacing simple string checks. In addition, components that display wallet or recipient data have been updated to utilize the usePrimaryName hook. A new JustaNameContext provider has been added to configure network connectivity for JustaName services.

Changes

File(s) Change Summary
.gitignore Removed duplicate entry for public/swe-worker*, re-added corrected entry, and added a new ignore for the .idea directory.
package.json Added dependencies: "@justaname.id/react" (^0.3.179) and "@justaname.id/sdk" (^0.2.176).
src/app/(mobile-ui)/history/page.tsx,
src/components/Create/Link/{Confirm,Initial,Input,Success}.tsx,
src/components/Global/{AddressInput,GeneralRecipientInput/*}.tsx,
src/utils/general.utils.ts
Introduced and integrated the validateEnsName utility for robust ENS name validation and updated recipient address formatting logic.
src/components/Global/{AddressLink,index.tsx},
src/components/Global/ListItemView/index.tsx,
src/components/Global/WalletHeader/index.tsx,
src/components/Home/WalletCard.tsx
Replaced useEnsName with the usePrimaryName hook and updated display logic to show primary names when available.
src/config/{justaname.config,wagmi.config}.tsx Added a new JustaNameContext provider component and wrapped children in context to configure network connectivity with Infura using environment variables.

Sequence Diagram(s)

sequenceDiagram
    participant UI as "UI Component"
    participant VN as "validateEnsName()"
    participant PA as "printableAddress()"
    UI->>VN: Validate recipient input
    VN->>PA: Format address if valid
    PA-->>VN: Return formatted address
    VN-->>UI: Return validated/ formatted name
Loading
sequenceDiagram
    participant A as "App"
    participant JC as "JustaNameContext"
    participant C as "Child Component"
    A->>JC: Initialize context with Infura API
    JC->>C: Provide primary name via usePrimaryName
    C->>JC: Request wallet primary name
    JC-->>C: Return primaryName or fallback
    C->>A: Render wallet details with primary name
Loading

Possibly related PRs

Suggested reviewers

  • Hugo0

Poem

I'm a bunny with code so nifty,
Hopping through changes quick and thrifty.
ENS names now validated with care,
Primary names shining bright out there.
With JustaName at the heart of our track,
I wiggle my nose and give a happy “hack!” 🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 774cda2 and 7eaa245.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (17)
  • .gitignore (1 hunks)
  • package.json (1 hunks)
  • src/app/(mobile-ui)/history/page.tsx (3 hunks)
  • src/components/Create/Link/Confirm.view.tsx (2 hunks)
  • src/components/Create/Link/Initial.view.tsx (3 hunks)
  • src/components/Create/Link/Input.view.tsx (2 hunks)
  • src/components/Create/Link/Success.view.tsx (2 hunks)
  • src/components/Global/AddressInput/index.tsx (2 hunks)
  • src/components/Global/AddressLink/index.tsx (1 hunks)
  • src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx (2 hunks)
  • src/components/Global/GeneralRecipientInput/index.tsx (2 hunks)
  • src/components/Global/ListItemView/index.tsx (4 hunks)
  • src/components/Global/WalletHeader/index.tsx (3 hunks)
  • src/components/Home/WalletCard.tsx (3 hunks)
  • src/config/justaname.config.tsx (1 hunks)
  • src/config/wagmi.config.tsx (2 hunks)
  • src/utils/general.utils.ts (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants