Oprava přidání tagu pro mazání cache#14
Merged
Merged
Conversation
jakubenglicky
commented
Mar 23, 2021
jakubenglicky
commented
- při nastavení tagu do dependencies této proměnné chybělo referencování
- tím pádem se sice v rámci metody tag nastavil, ale ven se již nedostal
- při nastavení tagu do dependencies této proměnné chybělo referencování - tím pádem se sice v rámci metody tag nastavil, ale ven se již nedostal
- z podstaty fungování není proměnná $dependencies naplněna, takže podmínka se nikdy nesplnila
- dependencies::TAGS se očekává jako pole, byť si s tím Cache poradí, zachoval bych formát pole. viz. https://doc.nette.org/cs/3.1/caching#toc-invalidace-pomoci-tagu
- vytvořena TestCase, která vytváří kontejner - úprava strktury složek
jakubenglicky
force-pushed
the
fix_clear_cache_dependencies
branch
from
38e9e57 to
8a5ab51
Compare
MilanPala
approved these changes
Mar 23, 2021
| protected $container; | ||
|
|
||
|
|
||
| public function setUp() |
There was a problem hiding this comment.
Suggested change
| public function setUp() | |
| public function setUp(): void |
- test, kontroluje zda při ukládání do cache jsou správně předány dependencies
jakubenglicky
force-pushed
the
fix_clear_cache_dependencies
branch
from
930dbcc to
7683c35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.