refactor(app): collect findings/layouts then render#34
Merged
Conversation
Turn Run's per-target render loop into collect-then-render: gather all findings (or layouts) across targets into one slice, then render once. Targets are already PkgPath-sorted and align sorts findings by file/offset, so concatenating in target order preserves the exact previous output. No behavior change — full test suite and golden fixtures pass unchanged. This is the foundation for the upcoming -summary/-sort/-threshold features. Closes #28 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns
app.Run's per-target render loop into collect-then-render: gather all findings (or layouts) across targets into one slice, then render once after the loop.Why: the upcoming
-summary,-sort, and-thresholdfeatures all need the full set of findings/layouts in hand before rendering (global sorting, aggregate totals, filtering). This refactor is the shared foundation; it lands first, on its own, so it can be reviewed purely as a no-op.No behavior change:
PkgPath-sorted andalignsorts findings by file/offset, so concatenating in target order preserves the exact previous output ordering.-update).task cigreen: tidy:check, lint, go-consistent, build, test, smoke.Closes #28
🤖 Generated with Claude Code