feat: report bytes saved in the diff header#57
Merged
Conversation
The diff header showed only a percentage, but -threshold filters by absolute bytes saved — so there was no number to read off when choosing a threshold. Append ", saving N bytes" (pluralized) before the existing "(NN.NN% smaller)" suffix, under the same condition (both sizes known and the proposal smaller). Mixed: struct of size 24 could be 16, saving 8 bytes (33.33% smaller) Updates the two diff golden fixtures and the README examples. Closes #56 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff header showed only a percentage, but
-thresholdfilters by absolute bytes saved — so there was no number to read off when deciding what threshold to pass. Now the header surfaces it:The "struct of size 24 could be 16" portion is the upstream analyzer's message (verbatim); structalign appends
, saving N bytes(pluralized) before the existing(NN.NN% smaller)suffix, under the same condition (both sizes known and the proposal smaller).Test plan
internal/ui/printer_test.go: assertion tightened tosaving 8 bytes (33.33% smaller).diff_unified_mixed.golden,diff_side_mixed.golden) — the only change is the header line; inspect goldens untouched.task cigreen (154 tests, 0 lint issues); verified against./_example.Closes #56
🤖 Generated with Claude Code