fix(usage): list -no-rc in -h and document the theme eggs#74
Merged
Conversation
The -no-rc flag was registered only inside scanEarlyFlags, so it never appeared in -h and the only mention lived in README. It is a normal config flag (no different from -threshold or -tags), not an easter egg, so register it with the FlagSet and keep an early peek just to honor it before RC loading runs. Adds a tiny "Easter eggs" README section documenting -cga / -green / -amber as shortcuts for STRUCTALIGN_THEME, and folds the dangling -version / -no-rc lines into the indented flag block. Closes #72.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-no-rcwith the regularflag.FlagSetso it appears in-houtput (it was only handled by the early-scan path before, which kept it invisible).-no-rcso the RC loader — which runs beforefs.Parse— can honor it, but no longer strips the flag fromargs;fs.Parsenow bindsopt.noRClike any other config flag.-cga,-green,-amberas shortcuts forSTRUCTALIGN_THEME=…(the only intentional eggs still hidden from-h).-version/-no-rclines in the README flag block into the indented list, matching the surrounding flags.Test plan
TestUsageHasManPageSectionsnow asserts-no-rcis present in usage output (RED before the fix, GREEN after).TestUsageOmitsEasterEggsupdated to drop the obsolete-no-rcexclusion; it still guards-fix,-cga,-green,-amber.TestRunLayeredConfig/NoRCpasses (RC loading skipped when-no-rcis on the command line).task ci— lint + go-consistent + build + full test suite + smoke.Closes #72.
🤖 Generated with Claude Code