feat: add node, disk, server, remote-command related command #1
feat: add node, disk, server, remote-command related command #1neverchanje merged 26 commits intopegasus-kv:mainfrom
Conversation
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return aggregate.NewPerfSession(addr), nil |
There was a problem hiding this comment.
use PerfClient instead, PerfSession is low level primitive.
There was a problem hiding this comment.
I know PerfClient, I only use one node session to query counter, but query all node and then filter one of them
executor/remote_command.go
Outdated
There was a problem hiding this comment.
i think we do not need remote command anymore
There was a problem hiding this comment.
So how to control the dynamic config? such as only_move_primary
executor/client.go
Outdated
There was a problem hiding this comment.
Call meta list nodes every time you validate an address... this is inefficient
There was a problem hiding this comment.
I can store it in cache at first call?
There was a problem hiding this comment.
Cache it in other places. Before calling validateReplicaAddress, you must ensure nodes are prepared already.
This is a basic responsibility separation principle. You can not list nodes in a validation function.
foreverneverer
changed the title
node and disk related command
foreverneverer
changed the title
foreverneverer
changed the title
cmd/remote_command.go
Outdated
There was a problem hiding this comment.
Basically no use case for remote-command all, remove this subcommand.
2 participants
Add commend:
command -hsee detail argument