Added support for two-column and narrow-wide templates in Banner temp… #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
26
to
32
| <div className='banner-layout' style={{gridTemplateColumns: b ? `${gridCols}` : '1fr'}}> | ||
| <div style={{ padding: '1em' }}> | ||
| {a} | ||
| </div> | ||
| <div style={{ padding: '1em' }}> | ||
| {b} | ||
| </div> |
Collaborator
There was a problem hiding this comment.
why are you not using React Material Grid?
Contributor
Author
There was a problem hiding this comment.
why are you not using React Material Grid?
As the div tag also worked in my case removed Material Grid, will update to Grid.
4manasa
force-pushed
the
mod/tor/US-536543-1
branch
from
5b9c66b to
7463480
Compare
added 3 commits
April 20, 2023 16:52
…react-sdk into mod/tor/US-536543-1
…mod/tor/US-536543-1
tumms2021389
requested changes
Apr 20, 2023
| const variantMap = { | ||
| 'two-column': [6, 6], | ||
| 'narrow-wide': [4, 8], | ||
| 'wide-narrow': [8,4] |
Collaborator
There was a problem hiding this comment.
lint: add space between ',' and 4
Comment on lines
102
to
112
| <Box | ||
| sx={{ flexGrow: 1, display: { xs: 'none', md: 'flex' } }} | ||
| style={{ justifyContent: alignment }} | ||
| > | ||
| {navLinks.map(link => ( | ||
| <Button className='link-style' key={link.text} onClick={link.onClick}> | ||
| {link.text} | ||
| </Button> | ||
| ))} | ||
| </Box> | ||
| )} |
Collaborator
There was a problem hiding this comment.
If it is the same code getting duplicated below, can we create a separate individual component for it?
Contributor
Author
There was a problem hiding this comment.
removed duplicate code
added 2 commits
April 20, 2023 19:12
…mod/tor/US-536543-1
tumms2021389
approved these changes
Apr 21, 2023
JEAxero
added a commit
that referenced
this pull request
Apr 24, 2023
* update react_pconnect to match dxcomponents (#303) * update react_pconnect to match dxcomponents * Added tests for TextInput, added a couple of tests in the unit test, and updated the structure of the tests folder (#307) * fix: view has no child text (#310) * fix: view has no child text * Added support for two-column and narrow-wide templates in Banner temp… (#306) * Added support for two-column and narrow-wide templates in Banner template Co-authored-by: manasa <manasa.mashetty@in.pega.com> --------- Co-authored-by: tumms2021389 <97188066+tumms2021389@users.noreply.github.com> Co-authored-by: Vishal Sharma <vishalshrm539@gmail.com> Co-authored-by: 4manasa <manasamashetty96@gmail.com> Co-authored-by: manasa <manasa.mashetty@in.pega.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…late