update pelias/sorting module to fix numeric sorting bug#1626
Merged
missinglink merged 2 commits intomasterfrom Jun 20, 2022
Merged
update pelias/sorting module to fix numeric sorting bug#1626missinglink merged 2 commits intomasterfrom
missinglink merged 2 commits intomasterfrom
Conversation
035d0a0 to
9998ba6
Compare
Member
Author
|
I've added a second commit which removes the
|
Member
Author
|
acceptance tests look good, there was one regression: /v1/search?sources=wof&text=Taman Taynton View, Malaysia
# previously
0) Taman Taynton View, Kuala Lumpur, Malaysia
1) Taman Taynton, Kuala Lumpur, Malaysia
# now
0) Taman Taynton, Kuala Lumpur, Malaysia
1) Taman Taynton View, Kuala Lumpur, MalaysiaThis is due to the results being displayed in order returned from I'm happy to merge this as-is, we can tackle the sorting order returned by placeholder in a subsequent PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fixes a subtle sorting bug: pelias/sorting#26
in particular, a user noted that the query
Acton, ME, USAreturned the result forMeeker Countyabove that ofMaine, which is now resolved.