Supports for single quotes in personal title#54
Merged
Conversation
missinglink
reviewed
Jun 27, 2019
Member
There was a problem hiding this comment.
Couple questions:
- Is the single-quote always in the second position or is that not always true?
- Is it possible to generate these synonyms at index-time rather than query-time? What difference would that make to performance and memory usage?
Note: you can use the 'backtick' in JS to avoid having to escape single quotes
Member
Author
With articles, the single-quote is always in the second position.
Oh! Yes, it's totally possible to generate synonyms at index time. For French personal titles from libpostal, there is only amiral which need to be generated => small CPU and memory footprint. That means I can add this directly here : This will also simplify this code 👍 Thanks 😄 |
684866d to
9495ccd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In the French grammar, there are 8 article
le,la,les,un,une,du,de,la. When an article likeleordeis used with a noun which starts with a vowel, the article's vowel is replaced by a simple quote. For example, we don't writeLe AmiralbutL'Amiral.So what ?
This PR fixes these edge cases which are common.
I think this should be spread in some other classifiers (such as
GivenNameClassifier)