Merged
Conversation
Member
|
Hey @josendf, |
Contributor
Author
|
Thank you Julian, we have updated the README. |
Member
|
Hey @josendf, thanks! I also saw you made another commit that looks like it changes the functionality of the code. Can you explain why that one's needed? |
Contributor
Author
|
Hi Julian, when updating the examples I've noticed that the focus view function requires to pass a subview, seems that the examples were outdated. |
Member
|
Oh! I didn't even realize it was in an example file. That's great, thanks for noticing! |
orangejulius
approved these changes
Apr 12, 2017
orangejulius
added a commit
that referenced
this pull request
Jul 5, 2017
A while back #61 changed all our queries to use Elasticsearch 5 compatible [bool queries](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-filtered-query.html) instead of the `filtered` queries that were deprecated in Elasticsearch 2, and no longer supported in Elasticsearch 5. However, while the queries were supposed to behave identically, it appears that a `filtered` query effectively had a `minimum_should_match` setting of 1 implied, while the new queries have a `minimum_should_match` of 0 implied. This was causing the new queries to return a bunch of irrelevant results, since any results that match the parent hierarchy filters would be returned, even if it did not match any of the should conditions. Our query logic depended on `minimum_should_match` being set to 1, so it's now explicitly set. Connects pelias/pelias#461 Connects pelias/api#762 Connects pelias/api#855
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We have ported the queries to ElasticSearch 5, we submit this pull request in case it can be of help.
The following has been performed:
The
filteredqueries were replaced byboolqueries, as explained inUpgrade & Get Started > Filtered query
Empty
filterclauses were removed as they affect performance (tested on ElasticSearch 5.3).Upgraded the affected tests.
Regards,