Add some more test cases for tokenization and ascii folding#501
Merged
missinglink merged 3 commits intopelias:masterfrom Feb 7, 2025
Merged
Add some more test cases for tokenization and ascii folding#501missinglink merged 3 commits intopelias:masterfrom
missinglink merged 3 commits intopelias:masterfrom
Conversation
orangejulius
approved these changes
Feb 3, 2025
Member
orangejulius
left a comment
There was a problem hiding this comment.
Looks good to me, these will be helpful tests to have as we take a look at #498
f038644 to
964cc43
Compare
Member
|
Hi @SiarheiFedartsou I just rebased Would you mind updating it to reflect the behaviour you were expecting from the |
Member
|
Are these failures expected? ✖ thai_tonemarks
-----------------
operator: deepEqual
expected: |-
{ '@pos0': [ 'กกกกขขขขคคคคฆฆฆฆ' ] }
actual: |-
{}✖ chinese_address
------------------
operator: deepEqual
expected: |-
{ '@pos0': [ '北京市朝阳区东三环中路1号国际大厦a座1001室' ] }
actual: |-
{} |
Contributor
Author
I doubt it :) I will look into it nearest days. Most likely we should have different expected results for ICU and no-ICU... |
964cc43 to
133e17b
Compare
Contributor
Author
|
@missinglink done. PTAL again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change 🚀
There are some questions in discussion of this PR #498, so I'd like to propose to extend a bit existing test harness to kind of document current state of the things. So current schema:
Here's what actually got changed 👏
Here's how others can test the changes 👀
Run tests :)