Skip to content

Conversation

@rmartinoscar
Copy link
Member

@rmartinoscar rmartinoscar commented Oct 10, 2025

Remove old settings & move write_limit, download_limit to corresponding categories

Summary by CodeRabbit

  • Documentation
    • Reorganized the Throttles section with simplified keys, a clearer “Default value” header, and improved table alignment.
    • Removed deprecated throttling keys from the main table.
    • Added new subsections: Backups Limits (write_limit) and Transfers Limits (download_limit), each with usage examples.
    • Updated and streamlined example formatting, with minor wording adjustments across throttling examples.

@netlify
Copy link

netlify bot commented Oct 10, 2025

Deploy Preview for pelica ready!

Name Link
🔨 Latest commit 601fc41
🔍 Latest deploy log https://app.netlify.com/projects/pelica/deploys/68e8eba735423f0008cfdafd
😎 Deploy Preview https://deploy-preview-171--pelica.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Oct 10, 2025

Walkthrough

Updates the optional configuration documentation for throttles by reorganizing keys, renaming a column header, and adjusting alignment. Moves write_limit and download_limit into new subsections (Backups Limits, Transfers Limits) with examples. Makes minor wording and formatting edits to existing examples.

Changes

Cohort / File(s) Summary
Docs – Throttles and Limits Reorganization
docs/wings/optional-config.mdx
Reworked Throttles table with shorter keys and renamed “Default Value” header; removed several keys from main table; added Backups Limits (write_limit) and Transfers Limits (download_limit) subsections with examples; minor wording/formatting adjustments to examples.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I thump my paws on docs so neat,
Trimmed the throttles, made them sweet.
Backups, Transfers—limits aligned,
Fresh examples, clearly defined.
Hop, hop—pages in fine arrays;
Carrots, commits, and tidier ways.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive The title reflects the fact that some settings are removed and others are reclassified, which aligns with the documented changes, but it remains generic and omits key details such as which settings are affected or that this pertains to the throttles documentation, making it harder to understand at a glance. Please revise the title to explicitly mention the throttles documentation and the specific settings (for example, “Reorganize Throttles docs: remove deprecated keys and move write_limit/download_limit to new subsections”) so that it clearly conveys the main changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/wingsOptionalConfig

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63e97ca and 601fc41.

📒 Files selected for processing (1)
  • docs/wings/optional-config.mdx (1 hunks)
🔇 Additional comments (1)
docs/wings/optional-config.mdx (1)

101-110: Clear documentation for backup throttling

Splitting the backup limits into their own section and spelling out the MiB/s behavior makes this much easier to understand at a glance. Nicely done.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rmartinoscar rmartinoscar merged commit 746ed53 into main Oct 10, 2025
5 checks passed
@rmartinoscar rmartinoscar deleted the chore/wingsOptionalConfig branch October 10, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants