-
Notifications
You must be signed in to change notification settings - Fork 55
Add info about routes to plugin docs #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for pelica ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughTwo duplicated "Routes" documentation blocks were added to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @docs/panel/advanced/plugins.mdx:
- Line 223: The Route definition in the docs contains an extra closing
parenthesis causing a PHP syntax error; update the Route::get example that
references TestController::class and the 'test' method to remove the trailing
extra ')' so the call to ->name('my-plugin.test') ends with a single closing
parenthesis only, ensuring the Route::get(...)->name(...) statement is
syntactically valid.
- Around line 210-236: The Route example has a stray closing parenthesis in the
Route::get line: change Route::get('test', [TestController::class,
'test'])->name('my-plugin.test')); to remove the extra ')' so the line ends with
->name('my-plugin.test'); ensuring the array [TestController::class, 'test'] and
the method chain terminate correctly.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.