Laravel 12.28.0 Shift#1652
Conversation
📝 WalkthroughWalkthroughUpdated composer.json to bump version constraints for several PHP dependencies (AWS SDK, Guzzle, Laravel framework and packages, Sanctum, Socialite, Spatie Permission). No other files or logic were changed. Changes
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
composer.json (1)
96-98: Align composer “platform.php” (8.2) with supported PHP (^8.2 || ^8.3 || ^8.4).With platform fixed at 8.2, dependency resolution won’t take advantage of PHP 8.3/8.4 builds and may mask 8.3/8.4 constraints. Consider setting platform.php to your production runtime (or removing it in CI and pinning only in release builds).
Example:
{
"config": {
"platform": { "php": "8.4" }
}
}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
composer.json(2 hunks)
🔇 Additional comments (3)
composer.json (3)
19-23: Upgrade to Laravel 12.28 and first‑party packages: run compatibility checks and full test pass.Looks good as constraints, but please verify no breaking changes in app code (auth, middleware, URL generation, Sanctum guards, Socialite providers). Also confirm no constraint conflicts with laravel/ui, tinker, spatie packages.
Suggested quick checks locally/CI:
- composer validate && composer update -W
- php artisan about && php artisan config:cache && php artisan route:cache
- php artisan migrate --pretend --no-interaction
- php artisan test or pest
- composer outdated --direct
13-13: AWS SDK bump: sanity‑check S3 integrations.Minimal risk, but confirm uploads, multipart operations, presigned URLs, and regional endpoints behave the same after update (esp. if using dualstack/accelerate).
40-40: spatie/laravel-permission bump: remember cache reset in deploys.No issues expected; ensure you run permission cache reset on deploy to avoid stale roles/permissions after update.
Command: php artisan permission:cache-reset
|
Superseded by #1651 |
This pull request includes updates for the recent minor version release of Laravel as well as bumps your package dependencies. You may review the full list of changes in the Laravel Release Notes, or highlighted changes and tips in the weekly Shifty Bits newsletter.
Before merging, you need to:
shift-ci-v12.28.0branchcomposer update