Skip to content

Conversation

@notAreYouScared
Copy link
Member

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Jan 18, 2026

📝 Walkthrough

Walkthrough

This PR updates two compiled JavaScript modules with identifier refactoring. The textarea component function is renamed with parameter adjustments and resize logic modifications to compute minimum height based on font size. The tables module includes an internal helper function rename.

Changes

Cohort / File(s) Summary
Textarea component
public/js/filament/forms/components/textarea.js
Default-exported function r renamed to n; parameters renamed (initialHeight: ie, shouldAutosize: si). Resize logic now calculates minimum height from computed font size and applies it conditionally to wrapper height.
Tables module
public/js/filament/tables/tables.js
Internal helper function J(e,t,i) renamed to q(e,t,i) with corresponding usage updates; no public API changes.

Possibly related PRs

  • composer update #1966: Modifies the same default-exported textarea component with function and parameter renaming changes
  • Filament v4.1 #1761: Contains widespread internal identifier renames across filament JavaScript files similar to this PR's refactoring pattern
🚥 Pre-merge checks | ❌ 3
❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'composer update' does not match the changeset, which involves JavaScript file modifications to textarea and tables components, not PHP composer dependencies. Update the title to accurately reflect the JavaScript changes, such as 'Refactor textarea and tables component functions' or similar.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to verify relatedness to the changeset. Add a description explaining the purpose and scope of these JavaScript function renamings and parameter changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@public/js/filament/forms/components/textarea.js`:
- Line 1: The ResizeObserver created in setUpResizeObserver() is not stored or
disconnected, causing a potential memory leak; update the component returned by
n(...) to save the observer (e.g., this._resizeObserver) when
setUpResizeObserver() creates it, and add a lifecycle cleanup (a destroy/uninit
method or inside init's teardown) that calls this._resizeObserver.disconnect()
and clears the reference; touch the init, setUpResizeObserver, and add a
destroy/cleanup method on the object returned by function n to ensure the
observer is disconnected when the component is removed.

@notAreYouScared notAreYouScared merged commit 6fe7d29 into main Jan 18, 2026
32 checks passed
@notAreYouScared notAreYouScared deleted the charles/composer-updatev2 branch January 18, 2026 21:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants