Add exception handling to CreateNode/ EditNode & CreateServer/ EditServer#411
Closed
Boy132 wants to merge 13 commits intopelican-dev:mainfrom
Boy132:fix/handle-exceptions
Closed
Add exception handling to CreateNode/ EditNode & CreateServer/ EditServer#411Boy132 wants to merge 13 commits intopelican-dev:mainfrom Boy132:fix/handle-exceptions
Boy132 wants to merge 13 commits intopelican-dev:mainfrom
Boy132:fix/handle-exceptions
Conversation
lancepioch
approved these changes
Jun 17, 2024
Member
lancepioch
left a comment
There was a problem hiding this comment.
Looks good, I wonder if we should use traits for now?
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Member
Author
Wouldn't #395 fix/ change that anyways? |
Member
|
It would, but who knows when that would be done. |
Member
This comment was marked as outdated.
This comment was marked as outdated.
# Conflicts: # app/Filament/Resources/NodeResource/Pages/CreateNode.php
Member
Author
|
Closing this for now. Will look into that later, probably. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







We probably want to add some more fine tuned exception handling at some point but for now this stops all 500 errors or silent errors and replaces them with a notification.