Skip to content

Comments

Add exception handling to CreateNode/ EditNode & CreateServer/ EditServer#411

Closed
Boy132 wants to merge 13 commits intopelican-dev:mainfrom
Boy132:fix/handle-exceptions
Closed

Add exception handling to CreateNode/ EditNode & CreateServer/ EditServer#411
Boy132 wants to merge 13 commits intopelican-dev:mainfrom
Boy132:fix/handle-exceptions

Conversation

@Boy132
Copy link
Member

@Boy132 Boy132 commented Jun 17, 2024

We probably want to add some more fine tuned exception handling at some point but for now this stops all 500 errors or silent errors and replaces them with a notification.

Copy link
Member

@lancepioch lancepioch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I wonder if we should use traits for now?

@Boy132 Boy132 requested a review from lancepioch June 17, 2024 14:04
@notAreYouScared

This comment was marked as outdated.

@Boy132 Boy132 marked this pull request as draft June 18, 2024 06:31
@Boy132 Boy132 marked this pull request as ready for review June 18, 2024 08:28
@Boy132 Boy132 requested a review from notAreYouScared June 18, 2024 08:28
@Boy132

This comment was marked as outdated.

@notAreYouScared
Copy link
Member

Anyway we can catch the 500 on the create allocation, on the create server page?

image
image
image

Unless we just need to rewrite the logic, the port already exists... we should just skip over it, and present an error saying something along the lines of

Failed to Create Allocation
Failed to Create: :,

@Boy132
Copy link
Member Author

Boy132 commented Jun 18, 2024

Anyway we can catch the 500 on the create allocation, on the create server page?

image image image

Unless we just need to rewrite the logic, the port already exists... we should just skip over it, and present an error saying something along the lines of

Failed to Create Allocation Failed to Create: :,

Wouldn't #395 fix/ change that anyways?

@notAreYouScared
Copy link
Member

It would, but who knows when that would be done.

@notAreYouScared
Copy link
Member

With latest changes 500's are still thrown when it skips the ports and does not return anything

image

@Boy132 Boy132 marked this pull request as draft June 18, 2024 22:06
@Boy132 Boy132 marked this pull request as ready for review June 21, 2024 11:19
@lancepioch lancepioch added this to the beta6 milestone Jun 25, 2024
lancepioch

This comment was marked as outdated.

@notAreYouScared

This comment was marked as outdated.

@lancepioch lancepioch removed this from the beta6 milestone Jun 26, 2024
@Boy132 Boy132 marked this pull request as draft June 27, 2024 12:55
Boy132 and others added 2 commits July 3, 2024 20:28
@Boy132
Copy link
Member Author

Boy132 commented Jul 8, 2024

Closing this for now. Will look into that later, probably.

@Boy132 Boy132 closed this Jul 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
@Boy132 Boy132 deleted the fix/handle-exceptions branch July 12, 2024 06:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants